USAGOV-2103: Add fed agency letter pages to the Pub Pages Report #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DaleMHFrey can you fix the phpcs lint errors, please? |
Oops, sorry! This is now fixed. |
|
@DaleMHFrey codesniffer linting is failing |
|
I've figured out what's going on across branches - circleci is running newer versions of drupal/coder and codesniffer. I'll make a ticket and fix things and keep you posted. |
omerida
requested changes
Jan 8, 2025
web/modules/custom/usagov_ssg_postprocessing/src/Drush/Commands/PublishedPagesCommands.php
Outdated
Show resolved
Hide resolved
omerida
requested changes
Jan 10, 2025
Oh shoot! sorry, fixed now |
omerida
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cm-jira.usa.gov/browse/USAGOV-2103
Description
Repeating write-line commands for the Agency-Letter pages to include all letters in the report.
Type of Changes
Testing Instructions
Run the
bin/static-sitescript. Check the Pub Pages report atweb/modules/custom/usagov_ssg_postprocessing/files/published-pages.csvand confirm the agency-letter pages show with/aand/b, and/c, etc, after them.Reviewer Reminders
Post PR Approval Instructions
Follow these steps as soon as you merge the new changes.
Review in Testand add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.