Skip to content

Commit

Permalink
[FIX] mail: less visible non-self message reaction in dark theme
Browse files Browse the repository at this point in the history
When message has emoji reactions, they have slightly different
visual whether the current user has reacted or not:
When the user has reacted, this is highlighted.

This works great in white them, but in dark theme the non-self
reacted visual was more highlighted, which goes against the
intend of highlighting self-reactions more. The problem is that
non-self reactions are too distracting in dark theme, which isn't
the case in white theme, This comes from borders being too visible.

The color of default `border` is too much in dark theme. This commit
fixes the issue by using `border-secondary`, which has reduced
opacity in dark theme. In white theme, this is unchanged.

closes odoo#190052

Signed-off-by: Didier Debondt (did) <[email protected]>
  • Loading branch information
alexkuhn committed Dec 9, 2024
1 parent 4d1d293 commit 66f3c57
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<t t-name="mail.MessageReactionList.button">
<button class="position-relative o-mail-MessageReaction btn d-flex p-0 border rounded-2 mb-1 fs-5 px-1 gap-1 align-items-center" t-on-click="() => this.onClickReaction(props.reaction)" t-on-contextmenu="onContextMenu" t-on-mouseenter="loadEmoji" t-ref="reactionButton" t-att-class="{
'o-selfReacted border-primary text-primary fw-bold': hasSelfReacted(props.reaction),
'bg-view': !hasSelfReacted(props.reaction),
'bg-view border-secondary': !hasSelfReacted(props.reaction),
'ms-1': env.inChatWindow and env.alignedRight,
'me-1': !(env.inChatWindow and env.alignedRight),
}">
Expand Down

0 comments on commit 66f3c57

Please sign in to comment.