[FIX] base,web: class attr for <graph/> & <pivot/>

Before this commit, the class attribute for <graph/> and <pivot/> views was not allowed. As there is no valid reason not to do so, this commit now allows it. Part-of: odoo#189786 Signed-off-by: Lucas Perais (lpe) <[email protected]>
ursais · Dec 9, 2024 · 22bbe42 · 22bbe42
1 parent 2a696c4
commit 22bbe42
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 0 deletions.
diff --git a/addons/web/static/tests/views/graph/graph_view.test.js b/addons/web/static/tests/views/graph/graph_view.test.js
@@ -177,6 +177,15 @@ defineModels([Foo, Color, Product]);
 
 setupChartJsForTests();
 
+test('graph view with "class" attribute', async () => {
+    await mountView({
+        type: "graph",
+        resModel: "foo",
+        arch: `<graph class="foobar-class"/>`,
+    });
+    expect(".o_graph_view").toHaveClass("foobar-class");
+});
+
 test("simple bar chart rendering", async () => {
     const view = await mountView({ type: "graph", resModel: "foo" });
 

diff --git a/addons/web/static/tests/views/pivot_view.test.js b/addons/web/static/tests/views/pivot_view.test.js
@@ -202,6 +202,15 @@ test('pivot view without "string" attribute', async () => {
     expect(model.metaData.title.toString()).toBe(_t("Untitled"));
 });
 
+test('pivot view with "class" attribute', async () => {
+    await mountView({
+        type: "pivot",
+        resModel: "partner",
+        arch: `<pivot class="foobar-class"/>`,
+    });
+    expect(".o_pivot_view").toHaveClass("foobar-class");
+});
+
 test("simple pivot rendering", async () => {
     expect.assertions(4);
 

diff --git a/odoo/addons/base/rng/graph_view.rng b/odoo/addons/base/rng/graph_view.rng
@@ -18,6 +18,7 @@
                     </rng:choice>
                 </rng:attribute>
             </rng:optional>
+            <rng:optional><rng:attribute name="class"/></rng:optional>
             <rng:optional><rng:attribute name="js_class"/></rng:optional>
             <rng:optional><rng:attribute name="stacked"/></rng:optional>
             <rng:optional><rng:attribute name="order"/></rng:optional>

diff --git a/odoo/addons/base/rng/pivot_view.rng b/odoo/addons/base/rng/pivot_view.rng
@@ -8,6 +8,7 @@
     <rng:include href="common.rng"/>
     <rng:define name="pivot">
         <rng:element name="pivot">
+            <rng:optional><rng:attribute name="class"/></rng:optional>
             <rng:optional><rng:attribute name="sample"/></rng:optional>
             <rng:optional><rng:attribute name="string"/></rng:optional>
             <rng:optional><rng:attribute name="stacked"/></rng:optional>