Avoid redefine identity #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #320 +/- ##
=======================================
Coverage 89.73% 89.74%
=======================================
Files 28 28
Lines 3176 3178 +2
Branches 576 577 +1
=======================================
+ Hits 2850 2852 +2
Misses 170 170
Partials 156 156 ☔ View full report in Codecov by Sentry. |
fdodino
approved these changes
Dec 2, 2024
src/validator/index.ts
Outdated
| }, []) |
There was a problem hiding this comment.
acá lo mismo, es un rompe el linter, hay que sacarle el ENTER al final del archivo
PalumboN
approved these changes
Dec 3, 2024
npasserini
pushed a commit
that referenced
this pull request
Dec 29, 2024
* method validation, should not redefine identity '===' * add isNative exception to identity override * Linter fixes --------- Co-authored-by: Fernando Dodino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #298