Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made so products include productCategory id #80

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Thizizmyname
Copy link
Member

Every product is placed in a category but the information were never passed with the product on a API-call, meaning you could never group them based on category.

The same issue was with the categories images.

@codecov
Copy link

codecov bot commented May 24, 2018

Codecov Report

Merging #80 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #80   +/-   ##
========================================
  Coverage    92.53%   92.53%           
========================================
  Files           83       83           
  Lines         3511     3511           
  Branches       189      189           
========================================
  Hits          3249     3249           
  Misses         224      224           
  Partials        38       38
Impacted Files Coverage Δ
src/foobar/rest/serializers/product.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c63e824...0f60480. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant