feat: allow skip-login #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarchri
approved these changes
Jan 13, 2025
adamwg
reviewed
Jan 13, 2025
action.yml
Outdated
| @@ -22,6 +22,9 @@ inputs: | |||
| public: | |||
| description: 'Create new repositories with public visibility' | |||
| default: 'false' | |||
| skip-login: | |||
There was a problem hiding this comment.
I'm torn on whether this should be called skip-login-check to more accurately describe what it does (since this action never does a login), or skip-login for consistency with action-up. Either way, it might be helpful to clarify what's being skipped in the description.
There was a problem hiding this comment.
I can update it to skip-login-check, that is a bit more explict. And will update description
There was a problem hiding this comment.
i think skip-login is clear enough, consistency ftw :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Allow people to skip-login check. This will let them use their own container registry.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested