-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement minimal built-in checks for Ibis backend #1885
Implement minimal built-in checks for Ibis backend #1885
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ibis-dev #1885 +/- ##
============================================
+ Coverage 92.76% 92.91% +0.14%
============================================
Files 133 134 +1
Lines 9705 9722 +17
============================================
+ Hits 9003 9033 +30
+ Misses 702 689 -13 ☔ View full report in Codecov by Sentry. |
3d0efc6
to
da8490f
Compare
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
da8490f
to
5744a4c
Compare
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
3f3f649
to
b97d493
Compare
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
4698e40
to
34daca5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @deepyaman, this looks great!
Do you plan on implementing the other built-in checks in a separate PR? If so we can go ahead and merge this
Yep, will do in a separate PR! |
This implements the built-in check machinery and a single validation (
equal_to
). In future PRs, I (or somebody else) can: