-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add overload. #1823
feat: add overload. #1823
Conversation
Signed-off-by: yassun7010 <[email protected]>
f7f2efe
to
62073f4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1823 +/- ##
==========================================
- Coverage 94.28% 93.29% -1.00%
==========================================
Files 91 120 +29
Lines 7013 9196 +2183
==========================================
+ Hits 6612 8579 +1967
- Misses 401 617 +216 ☔ View full report in Codecov by Sentry. |
thanks @yassun7010 ! please be sure to run the pre-commit checks: https://pandera.readthedocs.io/en/latest/CONTRIBUTING.html#set-up-pre-commit |
Signed-off-by: yassun7010 <[email protected]>
OK! pre-commit executed 🙇 |
Signed-off-by: yassun7010 <[email protected]>
5e3041e
to
5c52f3a
Compare
@yassun7010 looks like linter is still complaining... can you try performing the lint on a python 3.11 environment? |
Signed-off-by: yassun7010 <[email protected]>
1cd2e77
to
9a294d9
Compare
Thank you! It appears that pylint does not support overload. This writing is correct as overload, and the warning was ignored by the comment. |
@yassun7010 looks like the |
Signed-off-by: yassun7010 <[email protected]>
@cosmicBboy I fiexed and run |
Seems to be a failure in This appears to be a separate issue from this fix. |
thanks @yassun7010, and congrats on your first contribution to pandera! 🚀 |
Using the latest pylance,
pa.Int
, etc. will result in an error.This is because
Callable[[_DataTypeClass], _DataTypeClass]]
can now be correctly parsed and Callable is now a function and not a class.Defining override avoids problems in many cases, such as
pa.Int
.English Message is here.
Python 3.11.0
pylance v2024.9.2
pandas 2.2.2