-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate configs based on most primitive JSON types #683
Merged
maddenp-noaa
merged 16 commits into
ufs-community:main
from
maddenp-noaa:validate-all-json-types
Jan 13, 2025
Merged
Validate configs based on most primitive JSON types #683
maddenp-noaa
merged 16 commits into
ufs-community:main
from
maddenp-noaa:validate-all-json-types
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddenp-noaa
commented
Jan 8, 2025
maddenp-noaa
requested review from
Byrnetp,
NaureenBharwaniNOAA,
christinaholtNOAA and
elcarpenterNOAA
as code owners
January 8, 2025 01:59
NaureenBharwaniNOAA
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
Support validation (via CLI or API) of configs of
bool
,dict
,float
,int
,list
, orstr
types -- basically, all primitive JSON types except fornull
. Previously, validation of onlydict
-based configs was supported. Internally, driver andfs
-mode configs remaindict
-based, and for nowYAMLConfig
continues to support onlydict
-based configs, though this could be similarly generalized later.A config value with
str
type was perviously interpreted as a path to a file containing the config data to validate, so supportingstr
-based configs required splitting the formerconfig
argument intoconfig_data
andconfig_path
, where astr
value passed in to the former represents the config data itself, and astr
value passed in to the latter continues to represent a path to a file.Type
Impact
Checklist