-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging improvements in chgres_cube namelist creation #661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A handful of suggestions...
I think we might need a doc update based on these changes, but I can do that in a separate PR unless you want to give it a go. If you do, you can do . docs/install-deps
in your devshell to install the required packages, then -- and here I'd suggest having no other uncommitted changes -- do make docs
. You can then review the changes and undo any that are not pertinent to this change (e.g. lots of timestamps) before committing. It's possible that there won't be any changes worth keeping, but I'd be surprised.
Co-authored-by: Paul Madden <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I'll do the docs update if you don't get to it.
@maddenp-noaa I took a quick look at docs changes and didn't initially find any relevant to the changes to this PR, but I think it's worth another look if you wouldn't mind. I'll leave that for a future PR and merge this one. |
Synopsis
Fixes #621. Also changes some instances of arrow-delimited key paths
->
to dot-delimited key paths.
to be more consistent.Type
Impact
Checklist