Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvements in chgres_cube namelist creation #661

Merged
merged 9 commits into from
Nov 27, 2024

Conversation

Byrnetp
Copy link
Collaborator

@Byrnetp Byrnetp commented Nov 26, 2024

Synopsis

Fixes #621. Also changes some instances of arrow-delimited key paths -> to dot-delimited key paths . to be more consistent.

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a breaking change (changes existing functionality)
  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@Byrnetp Byrnetp self-assigned this Nov 26, 2024
src/uwtools/utils/tasks.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@maddenp-noaa maddenp-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A handful of suggestions...

I think we might need a doc update based on these changes, but I can do that in a separate PR unless you want to give it a go. If you do, you can do . docs/install-deps in your devshell to install the required packages, then -- and here I'd suggest having no other uncommitted changes -- do make docs. You can then review the changes and undo any that are not pertinent to this change (e.g. lots of timestamps) before committing. It's possible that there won't be any changes worth keeping, but I'd be surprised.

src/uwtools/utils/tasks.py Outdated Show resolved Hide resolved
src/uwtools/drivers/chgres_cube.py Outdated Show resolved Hide resolved
src/uwtools/drivers/chgres_cube.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@maddenp-noaa maddenp-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I'll do the docs update if you don't get to it.

@Byrnetp
Copy link
Collaborator Author

Byrnetp commented Nov 27, 2024

@maddenp-noaa I took a quick look at docs changes and didn't initially find any relevant to the changes to this PR, but I think it's worth another look if you wouldn't mind. I'll leave that for a future PR and merge this one.

@Byrnetp Byrnetp merged commit b253a6d into ufs-community:main Nov 27, 2024
2 checks passed
@Byrnetp Byrnetp deleted the logging-update branch November 27, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logging in chgres_cube namelist creation.
2 participants