Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax jsonschema pin #649

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

maddenp-noaa
Copy link
Collaborator

Synopsis

Relax the pin on jsonschema to permit the range 4.18 through 4.23, inclusive. This supports the installation of uwtools into environments with packages that also require jsonschema, pinned to a version in this range. (Specifically, a user wanted to install uwtools alongside the Globus Compute package, which pins to jsonschema 4.19.) Each minor release version was manually tested, and unit tests were updated to account for the different error messages emitted by jsonschema for different subsets of the range.

Probably other packages could get similar treatment (relaxed pinning), but more testing would be needed, and this this addresses the immediate blocker for our user.

I plan to do a same-version, incremented-build release based on this change.

Type

  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-noaa maddenp-noaa self-assigned this Nov 13, 2024
@maddenp-noaa maddenp-noaa merged commit fd3ada3 into ufs-community:main Nov 13, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the relax-jsonschema-pin branch November 13, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants