UW-501 / UW-502 FV3 graph-based driver implementation #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddenp-noaa
commented
Feb 11, 2024
maddenp-noaa
requested review from
christinaholtNOAA,
jprestop,
NaureenBharwaniNOAA,
elcarpenterNOAA,
fgabelmannjr and
WeirAE
as code owners
|
I went ahead and did the documentation updates in this PR. Preview docs are here. |
maddenp-noaa
commented
Feb 13, 2024
elcarpenterNOAA
approved these changes
Feb 14, 2024
NaureenBharwaniNOAA
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
Rework
forecastdriver asfv3driver, using task-graph techniques based on theiotaalibrary.Many of the unit tests are currently disabled and need to be updated, which I'll take care of before marking this PR ready to review, but the main library code is worth reviewing.Unit tests are back at 100%.There's a comment with at attached FV3 YAML config, and a path on
herawhere a sample run can be inspected.Documentation updates will follow in a separate PR.
Type
Impact
Checklist