Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.1.0 #397

Closed
wants to merge 67 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
7638236
uw-246 (#303)
maddenp-noaa Oct 4, 2023
4ddf53c
UW-382 Create JSONSchema section for dependency section tags (#292)
WeirAE Oct 5, 2023
4868c49
uw-317 (#305)
maddenp-noaa Oct 5, 2023
2bcee70
disconnect-jenkins (#308)
maddenp-noaa Oct 5, 2023
cbf3ef3
ci-publish-fixes (#311)
maddenp-noaa Oct 5, 2023
8cf2231
UW-312 Congealing the FV3Forecast Driver (#291)
christinaholtNOAA Oct 5, 2023
601ff4e
jq-formatting (#312)
maddenp-noaa Oct 6, 2023
2033263
release-workflow-case-fix (#319)
maddenp-noaa Oct 19, 2023
ac31f4e
UW 322 as a user, I would like to validate my rocoto xml workflow, gi…
WeirAE Oct 19, 2023
4291155
Fix command-line use of uw rocoto (#321)
WeirAE Oct 20, 2023
ae4ef70
switchable-logging (#320)
maddenp-noaa Oct 24, 2023
22503a3
rereadable-stdin (#325)
maddenp-noaa Oct 26, 2023
1cf4220
UW-413: Ensure CLI functions accept file and stdin streams for both i…
WeirAE Oct 26, 2023
e90fac4
UW-376 (#326)
maddenp-noaa Oct 31, 2023
a6335ce
post-uw-376-items (#328)
maddenp-noaa Oct 31, 2023
ac5879a
cli-test-fixup (#331)
maddenp-noaa Oct 31, 2023
8957f80
UW-412: expand tests to also not provide optional args (#330)
WeirAE Nov 1, 2023
5c14776
UW-365 (#332)
maddenp-noaa Nov 1, 2023
6a99d9e
UW-408: Refactor of forecast's run method (#327)
elcarpenterNOAA Nov 2, 2023
2e4cff3
UW-363 (#334)
maddenp-noaa Nov 2, 2023
5de7088
UW-407 (#335)
maddenp-noaa Nov 3, 2023
953e9a7
UW-364 (#338)
maddenp-noaa Nov 6, 2023
93ed4d1
ci-improvements (#342)
maddenp-noaa Nov 9, 2023
7f77a80
UW-370 (#340)
maddenp-noaa Nov 15, 2023
dccc67e
Update PR template (#343)
maddenp-noaa Nov 16, 2023
c2681e7
UW-371: refactor of render() (#346)
elcarpenterNOAA Nov 17, 2023
051b6d3
UW-415 (#341)
NaureenBharwaniNOAA Nov 21, 2023
3c93dfa
UW-418: Split .ini & .sh handling (#348)
WeirAE Nov 21, 2023
d6319db
UW-438 (#349)
maddenp-noaa Nov 27, 2023
6af0c64
cycledef-fixup (#351)
maddenp-noaa Nov 30, 2023
66aeb5f
Dependency Package Update 2023-11-30 (#356)
maddenp-noaa Nov 30, 2023
f9d3147
UW-386 (#354)
maddenp-noaa Dec 1, 2023
05923a6
UW-420: Forbid level-incompatible config transformations (#353)
WeirAE Dec 6, 2023
2c41888
UW-439 (#357)
maddenp-noaa Dec 6, 2023
ee5e381
UW-440 & UW-442 (#358)
maddenp-noaa Dec 8, 2023
74e9197
Misc updates 2023-12-06 (#359)
maddenp-noaa Dec 12, 2023
6fa5c9c
UW-421: Replace uw config realize --values-file with --supplemental-c…
elcarpenterNOAA Dec 20, 2023
9f9d13f
UW-454 (#367)
maddenp-noaa Dec 20, 2023
0ab2888
Add make target to remove development environment (#368)
maddenp-noaa Dec 20, 2023
9f872da
Fixing CLI config validate (#375)
WeirAE Jan 4, 2024
7bf7984
doc-update (#381)
maddenp-noaa Jan 11, 2024
bfe4bd4
Update RTD badge
maddenp-noaa Jan 11, 2024
e35411c
Fix doc links in README.md
maddenp-noaa Jan 12, 2024
884f6d9
conda-pkg-install-docs (#382)
maddenp-noaa Jan 12, 2024
b22cf75
typo-and-whitespace-fixes (#383)
maddenp-noaa Jan 16, 2024
725ed3e
UW-472 (#384)
maddenp-noaa Jan 16, 2024
97f7474
UW-474 (#385)
maddenp-noaa Jan 17, 2024
43e2be1
UW-477 (#386)
maddenp-noaa Jan 17, 2024
5189cf7
UW-476 (#387)
maddenp-noaa Jan 17, 2024
965d8dd
tagged-scalars (#388)
maddenp-noaa Jan 19, 2024
e578ffd
nml-updates (#392)
maddenp-noaa Jan 23, 2024
ad08cc1
Fixes to forecast driver found while testing. (#378)
christinaholtNOAA Jan 24, 2024
713d19c
UW433: Forecast docs (#389)
christinaholtNOAA Jan 24, 2024
24fb5c9
UW-419 (#393)
maddenp-noaa Jan 24, 2024
e5d2462
UW-479: add uw --debug CLI option (#391)
WeirAE Jan 24, 2024
0a2e998
typechecking-updates (#394)
maddenp-noaa Jan 24, 2024
58e4090
main-updates (#396)
maddenp-noaa Jan 24, 2024
4eb63b8
Squashed commit of the following:
maddenp-noaa Jan 24, 2024
142fdf8
Remove unneeded Actions scripts, fix whitespace
maddenp-noaa Jan 24, 2024
1b3ddf2
Squashed commit of the following:
maddenp-noaa Jan 25, 2024
5cb9bf6
Post-merge fixup
maddenp-noaa Jan 25, 2024
37bda95
Trigger release workflow via pull_request, workflow_dispath
maddenp-noaa Jan 25, 2024
8b39e1f
Test commit
maddenp-noaa Jan 25, 2024
5a97a75
Undo test commit
maddenp-noaa Jan 25, 2024
6647d3b
Merge branch 'develop' into release-v1.1.0
maddenp-noaa Jan 25, 2024
c9e3d49
Trigger release workflow only on push to main
maddenp-noaa Jan 25, 2024
369ba88
Trigger test workflow for main branch
maddenp-noaa Jan 25, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# See https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

# Side-wide code owners:
# Code owners:

* @NaureenBharwaniNOAA @christinaholtNOAA @elcarpenterNOAA @fgabelmannjr @maddenp-noaa @weirae

# Documentation-system config owners:
# Documentation owners:

.readthedocs.yaml @christinaholtNOAA @jprestop @maddenp-noaa
docs/* @christinaholtNOAA @jprestop @maddenp-noaa
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Your desired feature may already have an issue created!
If so, please consider using that Issue to expand on the feature capabilities or requirements.

Your bug may have already been reported!
Please look through the existing issues on the [Issue tracker](https://github.com/ufs-community/workflow-tools/issues) to see if this issue has been created.
Please look through the existing issues on the [Issue tracker](https://github.com/ufs-community/uwtools/issues) to see if this issue has been created.
If so, please consider using that Issue to add any additional information.

**Expected behavior**
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Please copy any output files into a Github gist (for e.g.) and link to the gist,
If this is a bug, please consider using the [Bug Report](./bug_report.md) template.
Your issue may already have been created!

Please look through the existing issues on the [Issue tracker](https://github.com/ufs-community/workflow-tools/issues) to see if this issue has been created.
Please look through the existing issues on the [Issue tracker](https://github.com/ufs-community/uwtools/issues) to see if this issue has been created.
If so, please consider using that Issue to add any additional information.

**Description**
Expand Down
72 changes: 25 additions & 47 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,61 +1,39 @@
<!--
- - - I N S T R U C T I O N S -- P L E A S E R E A D - - -
Please remove boiler plate instructions when filling out this template.
Please remove unwanted/unrelated/irrelevant information such as comments provided as a reference in this template.
Use proper formatting to separate code snippets from text description e.g. use ```code block``` or `in-line code`.
Please copy any output files into a Github gist (for e.g.) and link to the gist, rather than relying on paths on platforms that might change or disappear.

Before opening a PR, please note these guidelines:

- Each PR should only address ONE topic and have an associated GitHub issue
- No hardcoded or paths to personal directories should be present
- No temporary or backup files should be committed
- Any code that was disabled by being commented out should be removed
- Please provide a on-line, but descriptive title to the PR e.g. Adds XYZ functionality or Fixes ABC bugs, etc. DO NOT use branch names as titles.
-->

**Description**
INSTRUCTIONS

<!-- Please include relevant motivation and context. -->
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- List any dependencies that are required for this change. -->
- Please do not commit temporary, backup, or binary files.
- Please remove commented-out code.
- Please ensure code, config files, etc., contain no hardcoded paths.
- Please format code snippets in PR description/comments with ```code block``` or `inline code`.
- Please consider adding your own review comments to guide other reviewers.

<!-- Please provide reference to the issue this pull request is addressing. -->
<!-- For e.g. Fixes #IssueNumber -->
-->

**Type of change**
**Synopsis**

Please delete options that are not relevant.
<!-- A summary of the change, including relevant motivation, context, useful links, etc. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
**Type**

**How Has This Been Tested?**
<!-- Select one or more -->

<!-- Please describe the tests that you ran to verify your changes. -->
<!-- Provide instructions so we can reproduce. -->
<!-- Please also list any relevant details for your test configuration -->
- [ ] Bug fix (corrects a known issue)
- [ ] Code maintenance (refactoring, etc. without behavior change)
- [ ] Documentation
- [ ] Enhancement (adds a new functionality)
- [ ] Tooling (CI, code-quality, packaging, revision-control, etc.)

<!-- Use the following as a guide to list your tests and delete options that are not relevant. Expand as necessary. -->
<!--
- [ ] pytests in GitHub actions.
- [ ] Tests on XYZ OS/HPC/CSP
-->
**Impact**

**Checklist**
<!-- Select one -->

- [ ] This is a non-breaking change (existing functionality continues to work as expected)
- [ ] This is a breaking change (changes existing functionality)

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] My changes need updates to the documentation. I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] New and existing tests pass with my changes
- [ ] Any dependent changes have been merged and published
**Checklist**

<!--
If there is a co-author attribution:
<!-- Affirm -->

Update the final commit message (when squashing and merging) to include `Co-authored-by: name <[email protected]>` (e.g. `Co-authored-by: Jane Doe <[email protected]>`). Each co-author must have their own line, and the email address used must be the email address connected with their GitHub account.
-->
- [ ] I have added myself and any co-authors to the PR's _Assignees_ list.
- [ ] I have reviewed the documentation and have made any updates necessitated by this change.
47 changes: 0 additions & 47 deletions .github/scripts/build-documentation

This file was deleted.

9 changes: 9 additions & 0 deletions .github/scripts/common.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Shared resources for workflow scripts.

CI_CONDA_DIR=/tmp/conda
CI_CONDA_SH=$CI_CONDA_DIR/etc/profile.d/conda.sh

ci_conda_activate() {
source $CI_CONDA_SH
conda activate
}
17 changes: 17 additions & 0 deletions .github/scripts/format-check.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Actions invokes script with: bash -e <script>

set -a

unformatted() {
set -x
make format
if [[ -n "$(git status --porcelain)" ]]; then
(set +x && echo UNFORMATTED CODE DETECTED)
return 1
fi
return 0
}

source $(dirname ${BASH_SOURCE[0]})/common.sh
ci_conda_activate
CONDEV_SHELL_CMD=unformatted condev-shell
11 changes: 0 additions & 11 deletions .github/scripts/install-conda

This file was deleted.

11 changes: 11 additions & 0 deletions .github/scripts/install-conda.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Actions invokes script with: bash -e <script>

set -ux
source $(dirname ${BASH_SOURCE[0]})/common.sh
url=https://github.com/conda-forge/miniforge/releases/download/23.1.0-4/Miniforge3-23.1.0-4-Linux-x86_64.sh
installer=/tmp/$(basename $url)
wget --no-verbose -O $installer $url
bash $installer -bfp $CI_CONDA_DIR
set +ux
ci_conda_activate
conda install --quiet --yes --channel maddenp --repodata-fn repodata.json anaconda-client condev
9 changes: 9 additions & 0 deletions .github/scripts/link-check.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Actions invokes script with: bash -e <script>

set -a

source $(dirname ${BASH_SOURCE[0]})/common.sh
ci_conda_activate
cd docs
source install-deps
make linkcheck
5 changes: 0 additions & 5 deletions .github/scripts/make-package

This file was deleted.

6 changes: 6 additions & 0 deletions .github/scripts/make-package.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Actions invokes script with: bash -e <script>

source $(dirname ${BASH_SOURCE[0]})/common.sh
ci_conda_activate
set -x
make package
7 changes: 3 additions & 4 deletions .github/scripts/publish → .github/scripts/publish.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
#!/bin/bash -eux
# Actions invokes script with: bash -e <script>

set +ux
source conda/etc/profile.d/conda.sh
conda activate
source $(dirname ${BASH_SOURCE[0]})/common.sh
ci_conda_activate
set -ux
f=recipe/meta.json
glob="$(jq -r .name $f)-$(jq -r .version $f)-*_$(jq -r .buildnum $f).tar.bz2"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#!/bin/bash -eux
# Actions invokes script with: bash -e <script>

set -ux
f=recipe/meta.json
tag=v$(jq -r .version $f)-$(jq -r .buildnum $f)
if git ls-remote --tags origin | grep -q "/$tag$"; then
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#!/bin/bash -eux
# Actions invokes script with: bash -e <script>

set -ux
f=recipe/meta.json
tag=v$(jq -r .version $f)-$(jq -r .buildnum $f)
git tag $tag
Expand Down
22 changes: 22 additions & 0 deletions .github/scripts/test.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Actions invokes script with: bash -e <script>

set -a

SUPPORTED_PYTHON_VERSIONS=( 3.9 3.10 3.11 )

run_tests() {
echo TESTING PYTHON $PYTHON_VERSION
conda install --quiet --yes --repodata-fn repodata.json python=$PYTHON_VERSION
set -x
pip install --editable src # set new Python version in entry-point scripts
python --version
make test
return $?
}

source $(dirname ${BASH_SOURCE[0]})/common.sh
ci_conda_activate
for version in ${SUPPORTED_PYTHON_VERSIONS[*]}; do
PYTHON_VERSION=$version
CONDEV_SHELL_CMD=run_tests condev-shell
done
33 changes: 0 additions & 33 deletions .github/workflows/docs.yaml

This file was deleted.

21 changes: 0 additions & 21 deletions .github/workflows/make-package.yaml

This file was deleted.

16 changes: 10 additions & 6 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: release
name: Release
env:
ANACONDA_TOKEN: ${{ secrets.ANACONDA_TOKEN }}
on:
Expand All @@ -12,12 +12,16 @@ jobs:
steps:
- uses: actions/checkout@v3
- name: Install conda
run: .github/scripts/install-conda
run: .github/scripts/install-conda.sh
- name: Docs Link Check
run: .github/scripts/link-check.sh
- name: Format Check
run: .github/scripts/format-check.sh
- name: Make Package
run: .github/scripts/make-package
run: .github/scripts/make-package.sh
- name: Check For Existing Tag
run: .github/scripts/tag-check
run: .github/scripts/tag-check.sh
- name: Tag
run: .github/scripts/tag-create
run: .github/scripts/tag-create.sh
- name: Publish
run: .github/scripts/publish
run: .github/scripts/publish.sh
Loading