Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ugwpv1 timing / remove some extended WLCLK cases & PR#2491 Updates from the jedi model convention #2543

Merged
merged 15 commits into from
Jan 13, 2025

Conversation

dpsarmie
Copy link
Collaborator

@dpsarmie dpsarmie commented Dec 19, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR will fix an issue with the export_ugwpv1() function in default_vars.sh. The sedi_semi check was inverted. This should now align with the GW spec.
Changing this timestep also required some changes in the K_SPILT and N_SPLIT variables for select regression tests.
These fixes also reduced the runtime of some regression tests. Those tests had the custom changes to WLCLK removed since they are running under the 30 min limit.
A new namelist variable was also added (XR_CNVCLD) to more closely align with the GW namelist needs.

Commit Message:

* UFSWM - Fix sedi_semi logic issue in export_ugwpv1() and change affected RTs for more stable and quicker runtimes.
* UFSWM - Alias update JEDI-related variables inside the fd_ufs.yaml file.

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • GaeaC6
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@dpsarmie dpsarmie changed the title Fix ugwpv1 timing / remove some extended WLCLK cases Fix ugwpv1 timing / remove some extended WLCLK cases & PR#2491 Updates from the jedi model convention Dec 30, 2024
@dpsarmie
Copy link
Collaborator Author

Changes from PR #2491 have been added

@dpsarmie dpsarmie closed this Jan 6, 2025
@dpsarmie dpsarmie reopened this Jan 6, 2025
@jkbk2004 jkbk2004 added Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ort run ORT testing labels Jan 9, 2025
@jkbk2004 jkbk2004 removed the jenkins-ort run ORT testing label Jan 9, 2025
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jan 9, 2025

Hera disk quota issue is encountered on epic workspace. We will skip ORT runs.

@FernandoAndrade-NOAA FernandoAndrade-NOAA merged commit c7412fa into ufs-community:develop Jan 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEDI_SEMI incorrectly halves DT_ATMOS in tests/default_vars.sh
6 participants