-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ugwpv1 timing / remove some extended WLCLK cases & PR#2491 Updates from the jedi model convention #2543
Merged
FernandoAndrade-NOAA
merged 15 commits into
ufs-community:develop
from
dpsarmie:fix/ugwpv1_timing
Jan 13, 2025
Merged
Fix ugwpv1 timing / remove some extended WLCLK cases & PR#2491 Updates from the jedi model convention #2543
FernandoAndrade-NOAA
merged 15 commits into
ufs-community:develop
from
dpsarmie:fix/ugwpv1_timing
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpsarmie
changed the title
Fix ugwpv1 timing / remove some extended WLCLK cases
Fix ugwpv1 timing / remove some extended WLCLK cases & PR#2491 Updates from the jedi model convention
Dec 30, 2024
14 tasks
Changes from PR #2491 have been added |
dpsarmie
force-pushed
the
fix/ugwpv1_timing
branch
from
January 6, 2025 03:17
f8f151e
to
76471dc
Compare
jkbk2004
added
Baseline Updates
Current baselines will be updated.
Ready for Commit Queue
The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
jenkins-ort
run ORT testing
labels
Jan 9, 2025
dpsarmie
commented
Jan 9, 2025
Hera disk quota issue is encountered on epic workspace. We will skip ORT runs. |
FernandoAndrade-NOAA
approved these changes
Jan 13, 2025
jkbk2004
approved these changes
Jan 13, 2025
BrianCurtis-NOAA
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Baseline Updates
Current baselines will be updated.
Ready for Commit Queue
The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Description:
This PR will fix an issue with the
export_ugwpv1()
function in default_vars.sh. Thesedi_semi
check was inverted. This should now align with the GW spec.Changing this timestep also required some changes in the
K_SPILT
andN_SPLIT
variables for select regression tests.These fixes also reduced the runtime of some regression tests. Those tests had the custom changes to
WLCLK
removed since they are running under the 30 min limit.A new namelist variable was also added (
XR_CNVCLD
) to more closely align with the GW namelist needs.Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: