Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications for ufs-coastal app #2396

Open
wants to merge 51 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
ac77231
add changes to test uwm w/ coastal changes
DeniseWorthen Aug 8, 2024
e0e91ea
baseline test for ww3 19f7a276
DeniseWorthen Aug 9, 2024
dca62c5
update WW3, remove unused aliases from fd
DeniseWorthen Aug 12, 2024
0cdb63f
add test changes
DeniseWorthen Aug 12, 2024
ceca112
Merge branch 'develop' into feature/mods4coastalapp
DeniseWorthen Aug 13, 2024
574d396
fix indenting for linter
DeniseWorthen Aug 13, 2024
2c53d06
Merge branch 'develop' into feature/mods4coastalapp
DeniseWorthen Aug 21, 2024
de45d0e
update field dictionary aliases for SCHISM
DeniseWorthen Aug 21, 2024
e0691f1
Merge branch 'develop' into feature/mods4coastalapp
DeniseWorthen Aug 23, 2024
3d02d6f
Merge branch 'develop' into feature/mods4coastalapp
DeniseWorthen Aug 27, 2024
5901e0a
Merge branch 'ufs-community:develop' into feature/mods4coastalapp
DeniseWorthen Aug 30, 2024
23ce3ec
Merge branch 'develop' into feature/mods4coastalapp
DeniseWorthen Sep 3, 2024
7630c59
Merge branch 'develop' into feature/mods4coastalapp
DeniseWorthen Sep 9, 2024
8e3253c
point to new CICE branch in my fork
DeniseWorthen Sep 24, 2024
cc3bbe9
Revert "point to new CICE branch in my fork"
DeniseWorthen Sep 24, 2024
c242681
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Oct 2, 2024
db31e9f
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Oct 15, 2024
f0a358b
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Oct 18, 2024
a4444e7
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Oct 23, 2024
1f53677
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Nov 1, 2024
75f4e7d
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Nov 5, 2024
fbe0495
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Nov 12, 2024
ac0172e
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Nov 14, 2024
d4911ec
update WW3
DeniseWorthen Nov 14, 2024
3aaec72
Merge branch 'develop' into feature/mods4coastalapp
DeniseWorthen Nov 14, 2024
5dbecc8
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Dec 3, 2024
bcc1d7d
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Dec 5, 2024
88b8533
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Dec 6, 2024
30b6967
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Dec 12, 2024
c31603f
update WW3
DeniseWorthen Dec 12, 2024
b42472c
Merge branch 'develop' into feature/mods4coastalapp
DeniseWorthen Dec 12, 2024
18f833d
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Dec 16, 2024
f1b4963
Merge branch 'develop' into feature/mods4coastalapp
DeniseWorthen Dec 16, 2024
53b9c90
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Dec 19, 2024
3b131d5
Merge remote-tracking branch 'upstream/develop' into HEAD
DeniseWorthen Dec 24, 2024
a29762a
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Jan 2, 2025
32b8157
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Jan 3, 2025
f821642
Merge branch 'develop' into feature/mods4coastalapp
DeniseWorthen Jan 4, 2025
2d6b385
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Jan 10, 2025
40b43a2
Merge branch 'ufs-community:develop' into feature/mods4coastalapp
DeniseWorthen Jan 10, 2025
33e1b86
add empty test change list
DeniseWorthen Jan 11, 2025
b66da0d
point tMOM6 test branch
jiandewang Jan 13, 2025
bc0822d
modify MOM6 cmake list
jiandewang Jan 13, 2025
ddb79ce
Merge branch 'ufs-community:develop' into feature/update-MOM6-20241127
jiandewang Jan 13, 2025
f847448
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Jan 16, 2025
a87fd23
Merge branch 'ufs-community:develop' into develop
DeniseWorthen Jan 17, 2025
96ca82e
Merge branch 'ufs-community:develop' into feature/update-MOM6-20241127
jiandewang Jan 17, 2025
bdda71c
Merge branch 'develop' into feature/mods4coastalapp
DeniseWorthen Jan 17, 2025
5dacd52
point to MOM6 PR branch
DeniseWorthen Jan 17, 2025
56bfd86
Merge remote-tracking branch 'JW/feature/update-MOM6-20241127' into f…
DeniseWorthen Jan 17, 2025
8b8eac6
add hera RT log: passed
jkbk2004 Jan 18, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
branch = develop
[submodule "WW3"]
path = WW3
url = https://github.com/NOAA-EMC/WW3
branch = dev/ufs-weather-model
#url = https://github.com/NOAA-EMC/WW3
#branch = dev/ufs-weather-model
url = https://github.com/DeniseWorthen/WW3
branch = feature/addflds4schism
[submodule "stochastic_physics"]
path = stochastic_physics
url = https://github.com/NOAA-PSL/stochastic_physics
Expand All @@ -24,8 +26,10 @@
branch = emc/develop
[submodule "MOM6"]
path = MOM6-interface/MOM6
url = https://github.com/NOAA-EMC/MOM6
branch = dev/emc
#url = https://github.com/NOAA-EMC/MOM6
#branch = dev/emc
url = https://github.com/jiandewang/MOM6
branch = feature/update-to-main-20241127
[submodule "CICE"]
path = CICE-interface/CICE
url = https://github.com/NOAA-EMC/CICE
Expand Down
7 changes: 6 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ set(OPENMP ON CACHE BOOL "Enable OpenMP threading")
set(PARALLEL_NETCDF OFF CACHE BOOL "Enable parallel NetCDF")
set(JEDI_DRIVER OFF CACHE BOOL "Enable JEDI as top level driver")
set(CMEPS_AOFLUX OFF CACHE BOOL "Enable atmosphere-ocean flux calculation in mediator")
set(PDLIB OFF CACHE BOOL "Enable Domain Decomposition in WW3 via PDLIB")
set(PDLIB OFF CACHE BOOL "Enable Domain Decomposition in WW3 via PDLIB with BT1")
set(PDLIB_BT4 OFF CACHE BOOL "Enable Domain Decomposition in WW3 via PDLIB with BT4")
set(CDEPS_INLINE OFF CACHE BOOL "Enable CDEPS inline capability")
set(HYDRO OFF CACHE BOOL "Enable hydrostatic set")

Expand Down Expand Up @@ -217,8 +218,12 @@ if(WW3)
set(UFS_CAP "MULTI_ESMF" CACHE STRING "Build with MULTI_ESMF cap")
list(APPEND _ufs_defs_private FRONT_WW3=WMESMFMD)
else()
if(PDLIB OR PDLIB_BT4)
if(PDLIB)
set(SWITCH "meshcap_pdlib" CACHE STRING "NUOPC mesh cap")
else()
set(SWITCH "meshcap_pdlib_bt4" CACHE STRING "NUOPC mesh cap")
endif()
else()
set(SWITCH "meshcap" CACHE STRING "NUOPC mesh cap")
endif()
Expand Down
2 changes: 1 addition & 1 deletion MOM6-interface/MOM6
Submodule MOM6 updated 154 files
5 changes: 5 additions & 0 deletions MOM6-interface/mom6_files.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ list(APPEND mom6_src_files
MOM6/src/diagnostics/MOM_PointAccel.F90
MOM6/src/diagnostics/MOM_debugging.F90
MOM6/src/diagnostics/MOM_spatial_means.F90
MOM6/src/diagnostics/MOM_diagnose_MLD.F90
MOM6/src/diagnostics/MOM_diagnostics.F90
MOM6/src/diagnostics/MOM_harmonic_analysis.F90
MOM6/src/diagnostics/MOM_obsolete_diagnostics.F90
MOM6/src/diagnostics/MOM_obsolete_params.F90
MOM6/src/diagnostics/MOM_sum_output.F90
Expand Down Expand Up @@ -168,6 +170,7 @@ list(APPEND mom6_src_files
MOM6/src/parameterizations/lateral/MOM_tidal_forcing.F90
MOM6/src/parameterizations/lateral/MOM_Zanna_Bolton.F90
MOM6/src/parameterizations/lateral/MOM_self_attr_load.F90
MOM6/src/parameterizations/lateral/MOM_streaming_filter.F90

MOM6/src/parameterizations/vertical/MOM_ALE_sponge.F90
MOM6/src/parameterizations/vertical/MOM_CVMix_KPP.F90
Expand Down Expand Up @@ -312,7 +315,9 @@ list(APPEND mom6_nuopc_src_files
MOM6/config_src/drivers/unit_tests/test_MOM_mixedlayer_restrat.F90
MOM6/config_src/drivers/unit_tests/test_MOM_string_functions.F90
MOM6/config_src/drivers/unit_tests/test_MOM_EOS.F90
MOM6/config_src/drivers/unit_tests/test_MOM_remapping.F90
MOM6/config_src/drivers/timing_tests/time_MOM_EOS.F90
MOM6/config_src/drivers/timing_tests/time_MOM_remapping.F90
)

list(APPEND mom6_nuopc_src_files
Expand Down
2 changes: 1 addition & 1 deletion WW3
3 changes: 3 additions & 0 deletions tests/default_vars.sh
Original file line number Diff line number Diff line change
Expand Up @@ -1020,6 +1020,7 @@ export RST_BEG=${RUN_BEG}
export RST_2_BEG=${RUN_BEG}
export RST_END=${RUN_END}
export RST_2_END=${RUN_END}
export WW3_WLEV='F'
export WW3_CUR='F'
export WW3_ICE='F'
export WW3_IC1='F'
Expand Down Expand Up @@ -1321,6 +1322,7 @@ export_ww3() {
WW3_DTPNT="$(printf "%02d" $(( WW3_OUTDTHR*3600 )) )"
export WW3_DTFLD
export WW3_DTPNT
export WW3_WLEV='F'
export WW3_CUR='C'
export WW3_ICE='C'
export WW3_IC1='F'
Expand Down Expand Up @@ -1760,6 +1762,7 @@ export_hafs_regional ()
# default hafs with no ice
export WW3_DOMAIN=natl_6m
export WW3_MODDEF=mod_def.${WW3_DOMAIN}
export WW3_WLEV='F'
export WW3_ICE='F'
export WW3_OUTPARS="WND HS T01 T02 DIR FP DP PHS PTP PDIR UST CHA USP"
export WW3_RSTFLDS=" "
Expand Down
753 changes: 376 additions & 377 deletions tests/logs/RegressionTests_hera.log

Large diffs are not rendered by default.

76 changes: 55 additions & 21 deletions tests/parm/fd_ufs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -919,6 +919,61 @@ field_dictionary:
- standard_name: Sw_z0
alias: z0rlen
#
- standard_name: Sw_hs
alias: sea_surface_wave_significant_height
canonical_units: m
description: ww3 export - significant wave height
#
- standard_name: Sw_bhd
alias: sea_water_waves_effect_on_currents_bernoulli_head_adjustment
canonical_units: m2 s-2
description: ww3 export - Bernoulli head (J term)
#
- standard_name: Sw_tauox
alias: sea_surface_x_stress_due_to_waves
canonical_units: m2 s-2
description: ww3 export - wave to ocean momentum flux x
#
- standard_name: Sw_tauoy
alias: sea_surface_y_stress_due_to_waves
canonical_units: m2 s-2
description: ww3 export - wave to ocean momentum flux y
#
- standard_name: Sw_taubblx
alias: sea_bottom_upward_x_stress_due_to_waves
canonical_units: m2 s-2
description: ww3 export - momentum flux due to bottom friction x
#
- standard_name: Sw_taubbly
alias: sea_bottom_upward_y_stress_due_to_waves
canonical_units: m2 s-2
description: ww3 export - momentum flux due to bottom friction y
#
- standard_name: Sw_ubrx
alias: sea_bed_orbital_x_velocity_due_to_waves
canonical_units: m s-1
description: ww3 export - near bottom rms wave velocities x
#
- standard_name: Sw_ubry
alias: sea_bed_orbital_y_velocity_due_to_waves
canonical_units: m s-1
description: ww3 export - near bottom rms wave velocities y
#
- standard_name: Sw_thm
alias: sea_surface_wave_mean_direction
canonical_units: deg
description: ww3 export - mean wave direction
#
- standard_name: Sw_t0m1
alias: sea_surface_wave_mean_period
canonical_units: s
description: ww3 export - mean wave period
#
- standard_name: Sw_wnmean
alias: sea_surface_wave_mean_number
canonical_units: m-1
description: ww3 export - mean wave number
#
- standard_name: Sw_pstokes_x
alias: eastward_partitioned_stokes_drift_current
canonical_units: m s-1
Expand Down Expand Up @@ -967,27 +1022,6 @@ field_dictionary:
- standard_name: Sw_vstokes
alias: ussy
#
- standard_name: Sw_wbcuru
alias: eastward_wave_bottom_current
canonical_units: m s-1
description: ww3 export
- standard_name: Sw_wbcuru
alias: wbcuru
#
- standard_name: Sw_wbcurv
alias: northward_wave_bottom_current
canonical_units: m s-1
description: ww3 export
- standard_name: Sw_wbcurv
alias: wbcurv
#
- standard_name: Sw_wbcurp
alias: wave_bottom_current_period
canonical_units: s
description: ww3 export
- standard_name: Sw_wbcurp
alias: wbcurp
#
- standard_name: Sw_wavsuu
alias: eastward_wave_radiation_stress
canonical_units: N m-1
Expand Down
1 change: 1 addition & 0 deletions tests/parm/ww3_shel.nml.IN
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
&input_nml
input%forcing%water_levels = '@[WW3_WLEV]'
input%forcing%winds = 'C'
input%forcing%currents = '@[WW3_CUR]'
input%forcing%ice_conc = '@[WW3_ICE]'
Expand Down
Loading