MIDRC-848 Add /storage/credentials endpoints
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
paulineribeyre
force-pushed
the
feat/storage
branch
from
ca179b2 to
c7f1bfc
Compare
nss10
reviewed
Nov 12, 2024
| f"Too many existing keys: only {config['MAX_IAM_KEYS_PER_USER']} are allowed per user. Delete an existing key before creating a new one", | ||
| ) | ||
|
|
||
| key_id, key_secret = aws_utils.create_iam_user_and_key(user_id) |
There was a problem hiding this comment.
The AWS account role we need to assume this application with, must have a iam:CreateAccessKey. Doesn't this have to be mentioned in the docs?
There was a problem hiding this comment.
I think this comment becomes irrelevant, since all of that is taken care automatically in the cloud auto repo.
tests/test_storage.py
Outdated
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_torage_info(client, access_token_patcher): |
There was a problem hiding this comment.
Will approve once this is fixed then?
nss10
pushed a commit
that referenced
this pull request
Nov 13, 2024
nss10
pushed a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/MIDRC-848
New Features
/storage/credentialsendpoints to create, list and delete user credentials