Feat/current team project validation #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponent into TeamProjectHeader, should decrease total requests needed
…ode with an invalid teamProject application does not display the expired name
… to pass all unit tests
…lid.test.js to use existing test data
pieterlukasse
approved these changes
Nov 21, 2023
jarvisraymond-uchicago
merged commit cdd74d2
into
feat/vadc_sprint23
3 of 4 checks passed
jarvisraymond-uchicago
added a commit
that referenced
this pull request
Nov 27, 2023
* feat(currentTeamProjectValidation): Initial commit * feat(currentTeamProjectValidation): Moved logic outside of separate component into TeamProjectHeader, should decrease total requests needed * feat(currentTeamProjectValidation): refactored code so when in edit mode with an invalid teamProject application does not display the expired name * feat(currentTeamProjectValidation): began refactoring failed test * feat(currentTeamProjectValidation): Updated TeamProjectModel.test.jsx to pass all unit tests * feat(dataDownloadListActions): Removed dead code: InvalidTeamProjectMessage * feat(dataDownloadListActions): fixed lint issues * feat(currentTeamProjectValidation): updated unit tests to pass * feat(currentTeamProjectValidation): Updated story book stories * feat(currentTeamProjectValidation): removed duplicate function call * feat(currentTeamProjectValidation): Wrote unit test for IsCurrentTeamProjectValid * feat(currentTeamProjectValidation): updated function name for clarity * feat(currentTeamProjectValidation): removed console log and linted code * feat(currentTeamProjectValidation): Formatted code for clarity * feat(currentTeamProjectValidation): ran linter * feat(currentTeamProjectValidation): refactored IsCurrentTeamProjectValid.test.js to use existing test data * feat(currentTeamProjectValidation): removed unneeded localStorage set call * feat(currentTeamProjectValidation): ran linter * feat(currentTeamProjectValidation): cleaned up code for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: VADC-780
Updates the TeamProjectHeader to query for the current valid team projects and then validate the user's current stored team project. If the stored team project is not valid, the stored value is removed and they are redirected to the analysis app to select a new team project.
This can be tested locally by setting an invalid project name in the browser console:
localStorage.setItem('teamProject', '/bad_name');and then reloading the page when on the OHDSI, GWAS or Results app.
Storybooks and unit tests are update accordingly.
New Features