feat(dataDownloadListActions): Ran Eslint to format code, removed unn…

…eeded var from ActionButtons component
uc-cdis · Nov 9, 2023 · f5e8476 · f5e8476
1 parent c748668
commit f5e8476
Show file tree

Hide file tree

Showing 7 changed files with 39 additions and 47 deletions.
diff --git a/src/Discovery/DiscoveryDetails/DataDownloadList/ActionButtons/ActionButtons.tsx b/src/Discovery/DiscoveryDetails/DataDownloadList/ActionButtons/ActionButtons.tsx
@@ -9,7 +9,6 @@ import DownloadJsonFile from './DownloadUtils/DownloadJsonFile';
 const ActionButtons = ({
   discoveryConfig,
   resourceInfo,
-  data,
 }): JSX.Element => {
   const [downloadStatus, setDownloadStatus] = useState({
     inProgress: false,
@@ -32,13 +31,15 @@ const ActionButtons = ({
           </Button>
         </Col>
         */}
-        {discoveryConfig?.features.exportToWorkspace.studyMetadataFieldName &&
-          discoveryConfig?.features.exportToWorkspace.enableDownloadStudyMetadata &&
-          resourceInfo?.study_metadata &&
-          (
+        {discoveryConfig?.features.exportToWorkspace.studyMetadataFieldName
+          && discoveryConfig?.features.exportToWorkspace.enableDownloadStudyMetadata
+          && resourceInfo?.study_metadata
+          && (
             <Col flex='1 0 auto'>
-              <Button className='discovery-action-bar-button'
-              onClick={()=> DownloadJsonFile("study-level-metadata", resourceInfo.study_metadata)}>
+              <Button
+                className='discovery-action-bar-button'
+                onClick={() => DownloadJsonFile('study-level-metadata', resourceInfo.study_metadata)}
+              >
                 Download <br />
                 Study-Level Metadata
               </Button>
@@ -52,7 +53,7 @@ const ActionButtons = ({
                 HandleDownloadManifestClick(
                   discoveryConfig,
                   [resourceInfo],
-                  false
+                  false,
                 );
               }}
             >
@@ -64,9 +65,7 @@ const ActionButtons = ({
           <Col flex='1 0 auto'>
             <Button
               className='discovery-action-bar-button'
-              onClick={() =>
-                DownloadAllFiles(studyIDs, downloadStatus, setDownloadStatus)
-              }
+              onClick={() => DownloadAllFiles(studyIDs, downloadStatus, setDownloadStatus)}
             >
               Download All Files
             </Button>

diff --git a/src/Discovery/DiscoveryDetails/DataDownloadList/ActionButtons/ActionsButtons.test.tsx b/src/Discovery/DiscoveryDetails/DataDownloadList/ActionButtons/ActionsButtons.test.tsx
@@ -1,5 +1,5 @@
 import React from 'react';
-import { render, rerender } from '@testing-library/react';
+import { render } from '@testing-library/react';
 import '@testing-library/jest-dom';
 import ActionButtons from './ActionButtons';
 
@@ -27,18 +27,19 @@ describe('ActionButtons', () => {
         discoveryConfig={mockDiscoveryConfig}
         resourceInfo={null}
         data={mockData}
-      />
+      />,
     );
     // Check that the button is no longer rendered
     expect(queryByText(buttonText)).toBeNull();
-  }
+  };
 
-  const checkExportToWorkspaceConditional = (buttonText:string,condition: string )=>{
+  const checkExportToWorkspaceConditional = (buttonText:string, condition: string) => {
     const { getByText, queryByText, rerender } = render(
       <ActionButtons
         discoveryConfig={mockDiscoveryConfig}
         resourceInfo={mockResourceInfo}
-        data={mockData} />
+        data={mockData}
+      />,
     );
     const targetButton = getByText(buttonText);
     expect(targetButton).toBeInTheDocument();
@@ -50,29 +51,23 @@ describe('ActionButtons', () => {
         discoveryConfig={changedConfig}
         resourceInfo={mockResourceInfo}
         data={mockData}
-      />
+      />,
     );
     // Check that the button is no longer rendered
     expect(queryByText(buttonText)).toBeNull();
-  }
+  };
 
   /* TESTS */
   test('renders Download Study-Level Metadata button based on conditionals', () => {
-   const buttonText = 'Study-Level Metadata';
-   checkExportToWorkspaceConditional(buttonText, 'enableDownloadStudyMetadata');
-   checkExportToWorkspaceConditional(buttonText,'studyMetadataFieldName');
-   checkResourceInfoConditional(buttonText);
-
+    const buttonText = 'Study-Level Metadata';
+    checkExportToWorkspaceConditional(buttonText, 'enableDownloadStudyMetadata');
+    checkExportToWorkspaceConditional(buttonText, 'studyMetadataFieldName');
+    checkResourceInfoConditional(buttonText);
   });
-
   test('renders Download File Manifest button based on conditionals', () => {
-    checkExportToWorkspaceConditional('Download File Manifest','enableDownloadManifest' );
+    checkExportToWorkspaceConditional('Download File Manifest', 'enableDownloadManifest');
   });
   test('renders Download All Files button based on conditionals', () => {
-    checkExportToWorkspaceConditional('Download All Files','enableDownloadZip' );
+    checkExportToWorkspaceConditional('Download All Files', 'enableDownloadZip');
   });
-
-
-
-
 });
diff --git a/...iscoveryDetails/DataDownloadList/ActionButtons/DownloadAllModal/DownloadAllModal.test.tsx b/...iscoveryDetails/DataDownloadList/ActionButtons/DownloadAllModal/DownloadAllModal.test.tsx
@@ -1,5 +1,5 @@
 import React from 'react';
-import { render, fireEvent, screen } from '@testing-library/react';
+import { render, fireEvent } from '@testing-library/react';
 import '@testing-library/jest-dom/extend-expect';
 import DownloadAllModal from './DownloadAllModal';
 import DownloadStatus from '../../Interfaces/DownloadStatus';
@@ -22,7 +22,7 @@ test('DownloadAllModal renders correctly and closes on button click', () => {
     <DownloadAllModal
       downloadStatus={mockDownloadStatus}
       setDownloadStatus={mockSetDownloadStatus}
-    />
+    />,
   );
 
   // Check if the modal renders with the provided title and content

diff --git a/...covery/DiscoveryDetails/DataDownloadList/ActionButtons/DownloadUtils/DownloadAllFiles.tsx b/...covery/DiscoveryDetails/DataDownloadList/ActionButtons/DownloadUtils/DownloadAllFiles.tsx
@@ -4,8 +4,7 @@ import { jobAPIPath } from '../../../../../localconf';
 import DownloadStatus from '../../Interfaces/DownloadStatus';
 
 const JOB_POLLING_INTERVAL = 5000;
-const DOWNLOAD_SUCCEEDED_MESSAGE =
-  "Your download has been prepared. If your download doesn't start automatically, please follow this direct link:";
+const DOWNLOAD_SUCCEEDED_MESSAGE = 'Your download has been prepared. If your download doesn\'t start automatically, please follow this direct link:';
 
 const DOWNLOAD_FAIL_STATUS: DownloadStatus = {
   inProgress: false,
@@ -24,7 +23,7 @@ const DOWNLOAD_FAIL_STATUS: DownloadStatus = {
 const checkDownloadStatus = (
   uid: string,
   downloadStatus: DownloadStatus,
-  setDownloadStatus: (arg0: DownloadStatus) => void
+  setDownloadStatus: (arg0: DownloadStatus) => void,
 ) => {
   fetchWithCreds({ path: `${jobAPIPath}status?UID=${uid}` }).then(
     (statusResponse) => {
@@ -43,7 +42,7 @@ const checkDownloadStatus = (
                 inProgress: false,
                 message: {
                   title: 'Download failed',
-                  content: <p>{ output }</p> ,
+                  content: <p>{ output }</p>,
                   active: true,
                 },
               });
@@ -98,17 +97,17 @@ const checkDownloadStatus = (
           JOB_POLLING_INTERVAL,
           uid,
           downloadStatus,
-          setDownloadStatus
+          setDownloadStatus,
         );
       }
-    }
+    },
   );
 };
 
 const DownloadAllFiles = (
   studyIDs: any[],
   downloadStatus: DownloadStatus,
-  setDownloadStatus: (arg0: DownloadStatus) => void
+  setDownloadStatus: (arg0: DownloadStatus) => void,
 ) => {
   fetchWithCreds({
     path: `${jobAPIPath}dispatch`,
@@ -155,7 +154,7 @@ const DownloadAllFiles = (
           JOB_POLLING_INTERVAL,
           uid,
           downloadStatus,
-          setDownloadStatus
+          setDownloadStatus,
         );
       }
     })

diff --git a/...scovery/DiscoveryDetails/DataDownloadList/ActionButtons/DownloadUtils/DownloadJsonFile.ts b/...scovery/DiscoveryDetails/DataDownloadList/ActionButtons/DownloadUtils/DownloadJsonFile.ts
@@ -1,10 +1,10 @@
 import FileSaver from 'file-saver';
 
 const DownloadJsonFile = (fileName: string, data: object) => {
-    const blob = new Blob([JSON.stringify(data, null, 2)], {
-        type: 'text/json',
-      });
-      FileSaver.saveAs(blob, fileName +'.json');
-}
+  const blob = new Blob([JSON.stringify(data, null, 2)], {
+    type: 'text/json',
+  });
+  FileSaver.saveAs(blob, `${fileName}.json`);
+};
 
 export default DownloadJsonFile;
diff --git a/...coveryDetails/DataDownloadList/ActionButtons/DownloadUtils/HandleDownloadManifestClick.ts b/...coveryDetails/DataDownloadList/ActionButtons/DownloadUtils/HandleDownloadManifestClick.ts
@@ -34,7 +34,7 @@ const HandleDownloadManifestClick = (
       }
     }
   });
-  DownloadJsonFile('manifest', manifest)
+  DownloadJsonFile('manifest', manifest);
 };
 
 export default HandleDownloadManifestClick;
diff --git a/src/Discovery/DiscoveryDetails/DataDownloadList/DataDownloadList.tsx b/src/Discovery/DiscoveryDetails/DataDownloadList/DataDownloadList.tsx
@@ -19,7 +19,6 @@ const DataDownloadList = ({
       <ActionButtons
         discoveryConfig={discoveryConfig}
         resourceInfo={resourceInfo}
-        data={data}
       />
       <List
         itemLayout='horizontal'