Security review PR - Collection of all "team project" feature related changes #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and add both real and mock implementations. This makes this part easier to test.
...and add respective tests
Feat: add "team project" filtering to /cohortdefinition-stats endpoint
…_validation_for_team_project
...which is cohort_definition_id...there is no such thing as "cohort id"
…n_for_team_project Feat: integrate extra 'team project' validation for concept endpoints
Important: these can only be added back with proper changes to ensure the correct "team project" filtering takes place
...to support team projects that start with "/"
...over the other variation of this method (TeamProjectValidationForCohortIdsList)
…n_for_team_project_for_cohort_data_endpoints Feat: integrate Arborist validation for team project for cohort data endpoints AND remove unused endpoints
This reverts (part of) commit c38cfad.
Feat: team project feature
...for cases where authorization failed
...to ensure 403 is returned when TeamProjectValidationForCohort returns false
...to ensure 403 is returned when HasAccessToTeamProject returns false
Feat/add missing arborist checks
pieterlukasse
force-pushed
the
prerelease_040
branch
from
c929a06 to
922c748
Compare
pieterlukasse
commented
Jan 31, 2024
k-burt-uch
reviewed
Feb 6, 2024
pieterlukasse
force-pushed
the
prerelease_040
branch
from
6019838 to
9ab34c7
Compare
k-burt-uch
approved these changes
Feb 6, 2024
|
thanks for the approval @k-burt-uch . I'll move just the new commits to a separate PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Jira Ticket: VADC-618
New Features