Feat/add missing arborist checks #87

pieterlukasse · 2024-01-26T21:30:04Z

Jira Ticket: VADC-899

Add missing authorization checks for RetriveStatsBySourceIdAndTeamProject and RetriveById methods
Ensure "access denied" errors return StatusForbidden instead of StatusBadRequest

...for cases where authorization failed

...to ensure 403 is returned when TeamProjectValidationForCohort returns false

...to ensure 403 is returned when HasAccessToTeamProject returns false

tianj7

one minor comment regard test name

tests/middlewares_tests/middlewares_test.go

pieterlukasse added 2 commits January 26, 2024 20:53

feat: add missing arborist checks

75e4b48

fix: return StatusForbidden instead of StatusBadRequest

45b3110

...for cases where authorization failed

github-actions bot added the test-portal-homepageTest label Jan 26, 2024

pieterlukasse requested a review from tianj7 January 29, 2024 14:59

pieterlukasse added 3 commits January 29, 2024 16:44

feat: add new test for RetriveById

d4f3520

...to ensure 403 is returned when TeamProjectValidationForCohort returns false

feat: add new test for RetriveStatsBySourceIdAndTeamProject

91a922d

...to ensure 403 is returned when HasAccessToTeamProject returns false

feat: extra tests to cover some blind spots in teamprojectauthz

9b451e7

tianj7 reviewed Jan 30, 2024

View reviewed changes

tests/middlewares_tests/middlewares_test.go Outdated Show resolved Hide resolved

fix: better test name

aa75cb3

tianj7 approved these changes Jan 30, 2024

View reviewed changes

pieterlukasse merged commit 5e1839b into master Jan 30, 2024
10 of 11 checks passed

pieterlukasse deleted the feat/add_missing_arborist_checks branch January 30, 2024 15:30

Provide feedback