Add changes to ensure azlinux and mcrypt images are working fine #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nss10
commented
Dec 10, 2024
kube/services/jobs/usersync-job.yaml
Outdated
| @@ -93,7 +93,7 @@ spec: | |||
| name: "projects" | |||
| containers: | |||
| - name: usersync | |||
| GEN3_FENCE_IMAGE | |||
| GEN3_FENCE_MCRYPT_IMAGE | |||
There was a problem hiding this comment.
I think adding this, enforces all commons to have fence_mcrypt in their manifest and doesn't seem like a great idea
There was a problem hiding this comment.
Yeah... It will force every job to use the new image for the usersync job regardless of if they're using the latest Fence, which is going to change what every Prod env runs without them explicitly updating a manifest or anything. We shouldn't do this. It doesn't allow someone to test the update in a staging/preprod before deploying in prod. We want to only use this new image if they're deploying the new Fence as configured in the manifest. Maybe we need a new manifest entry
There was a problem hiding this comment.
I suggested adding a new fence_mcrypt image line in the manifest's versions, specifically for jobs where usersync requires this branch. The team would then need to manually update the usersync job in the AdminVM.
Need opinions.
AlbertSnows
previously approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Approved assuming the pipeline issues are resolved. can you add a description to the PR so I or other reviewers have a better understanding of the purposes of these changes? The PR looks fine, but due to lack of context there may be things I am missing. Getting another review from someone else will also be beneficial.
|
Please find the ci env pod logs here |
|
Please find the ci env pod logs here |
jawadqur
previously approved these changes
Jan 10, 2025
nss10
added
TestAuditService
test-apis-dbgapTest
TestGoogleDataAccess
TestDbgap
TestIndexingPage
and removed
test-apis-dbgapTest
labels
|
Please find the ci env pod logs here |
|
Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
|
Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
|
Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
|
Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add changes to fence related deploy yamls, to provide backwards compatibility with fence images using azlinux and old docker file with
python3.9-buster-2.0.0image