Use invisible address as displayed sender when sender name is empty

Because the sender's name is used as a fold mail button. An empty sender name results in an element with a height of zero, making it it impossible to click to fold mails. VoiceOver also does not focus the fold mail button when the sender name is empty. Close #8266 Close #8309 Co-authored-by: paw <[email protected]> Co-authored-by: ivk <[email protected]>
tutao · Jan 17, 2025 · 90d8fbd · 90d8fbd
1 parent c12c3b1
commit 90d8fbd
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/mail-app/mail/view/MailViewerHeader.ts b/src/mail-app/mail/view/MailViewerHeader.ts
@@ -192,6 +192,8 @@ export class MailViewerHeader implements Component<MailViewerHeaderAttrs> {
 	private renderSubjectActionsLine(attrs: MailViewerHeaderAttrs) {
 		const { viewModel } = attrs
 		const classes = this.makeSubjectActionsLineClasses()
+		const senderName = viewModel.getDisplayedSender()?.name?.trim() ?? ""
+		const displayAddressForSender = senderName === ""
 
 		return m(classes, [
 			m(
@@ -230,7 +232,10 @@ export class MailViewerHeader implements Component<MailViewerHeaderAttrs> {
 						  )
 						: null,
 					this.tutaoBadge(viewModel),
-					m("span.text-break" + (viewModel.isUnread() ? ".font-weight-600" : ""), viewModel.getDisplayedSender()?.name ?? ""),
+					m(
+						"span.text-break" + (viewModel.isUnread() ? ".font-weight-600" : "") + (displayAddressForSender ? ".invisible" : ""),
+						displayAddressForSender ? viewModel.getDisplayedSender()?.address : senderName,
+					),
 				],
 			),
 			m(