Ability to set/change an extent to the graticule and to change the interval #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gBounds to clamp the graticule layer to the current map view.
…for dynamic graticule intervals and extents
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added the ability to pass in/change an extent (such as the current map.getBounds()). This allows small intervals with very good performance when zoomed in. I also added the ability to change the interval. Changes to extents and intervals are set via a refresh() function. I created a demo to show the interval and extent changing as the user pans/zooms the map. Critiques are welcome, for example, the added extent functionality doesn't work so well with the Mollweide projection due to it's strange handling of map.getBounds() (when zoomed out, map.getBounds().getWest() and ...getEast() return 0)