feat(suite): solana staking transactions #16388
Conversation
| @@ -36,6 +36,7 @@ export const SYSTEM_PROGRAM_PUBLIC_KEY = '11111111111111111111111111111111'; | |||
| // WSOL transfers are denoted as transfers of SOL as well as WSOL, so we use this to filter out SOL values | |||
| // when parsing tx effects. | |||
| export const WSOL_MINT = 'So11111111111111111111111111111111111111112'; | |||
| export const STAKE_PROGRAM_ID = 'Stake11111111111111111111111111111111111111'; | |||
There was a problem hiding this comment.
| export const STAKE_PROGRAM_ID = 'Stake11111111111111111111111111111111111111'; | |
| export const STAKE_PROGRAM_PUBLIC_KEY = 'Stake11111111111111111111111111111111111111'; |
| const getSolTransactionStakeTypeName = (stakeType: StakeType) => { | ||
| switch (stakeType) { | ||
| case 'stake': | ||
| return 'Stake'; |
There was a problem hiding this comment.
possibly use localised strings?
There was a problem hiding this comment.
It would probably be good but I don't know if we want to translate it 😀
There was a problem hiding this comment.
We don't use translations for this on Ethereum, which is why I didn't localize them.
| @@ -65,8 +85,7 @@ export const SolStakingDashboard = ({ selectedAccount }: SolStakingDashboardProp | |||
| /> | |||
| </Column> | |||
| </DashboardSection> | |||
| {/* TODO: implement Transactions component */} | |||
| {/* <Transactions /> */} | |||
| <Transactions /> | |||
| const dispatch = useDispatch(); | ||
|
|
||
| useEffect(() => { | ||
| if (accountKey) { | ||
| dispatch( | ||
| fetchAllTransactionsForAccountThunk({ | ||
| accountKey, | ||
| noLoading: true, | ||
| }), | ||
| ); | ||
| } | ||
| }, [account, accountKey, dispatch]); |
| const getSolTransactionStakeTypeName = (stakeType: StakeType) => { | ||
| switch (stakeType) { | ||
| case 'stake': | ||
| return 'Stake'; |
There was a problem hiding this comment.
It would probably be good but I don't know if we want to translate it 😀
| const showFeeRowForSolClaim = transaction?.solanaSpecific?.stakeType === 'claim'; | ||
| const showFeeRow = isTxFeePaid(transaction) || showFeeRowForSolClaim; |
There was a problem hiding this comment.
is it needed? if yes can you move the logic into isTxFeePaid?
There was a problem hiding this comment.
I think it's needed. Otherwise, the claim has no fee row. Moved to isTxFeePaid 3d2878f
| <Row gap={spacings.xxs} overflow="hidden"> | ||
| <span>{getSolTransactionStakeTypeName(solanaStakeType)}</span> | ||
| {isSupportedSolStakingNetworkSymbol(transaction.symbol) && | ||
| solanaStakeType === 'unstake' && ( |
| // hide amount for solana unstake transactions | ||
| if (transaction?.solanaSpecific?.stakeType === 'unstake') { | ||
| amount = null; | ||
| } |
There was a problem hiding this comment.
on Ethereum, the amount for an unstake transaction is always 0, while for Solana, it is non-zero.
| if (type === 'delegate') return 'stake'; | ||
| if (type === 'deactivate') return 'unstake'; | ||
| if (type === 'withdraw') return 'claim'; |
There was a problem hiding this comment.
can those types be used also for different purposes than stake? @vytick
There was a problem hiding this comment.
Yes, but it depends on the referenced program to determine what are the types and what those mean.
There was a problem hiding this comment.
So is this decoding ok or not?
There was a problem hiding this comment.
Can there be some false positives?
dev-pvl
force-pushed
the
feat/solana-staking-transactions
branch
from
c16ba49 to
22753f5
Compare
Description
This PR adds support for processing Solana staking transactions. It includes:
Related Issue
Resolve
Screenshots: