chore(suite-native): introduce component tests #16387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbazant
force-pushed
the
testing-library
branch
from
726174f to
fdf88a9
Compare
|
🚀 Expo preview is ready!
|
jbazant
force-pushed
the
testing-library
branch
from
fdf88a9 to
44de5a8
Compare
Nodonisko
reviewed
Jan 15, 2025
suite-native/atoms/jest.config.js
Outdated
| @@ -0,0 +1,4 @@ | |||
| const { ...baseConfig } = require('../../jest.config.native'); | |||
There was a problem hiding this comment.
We are trying to avoid unecessary boilerplate files for packages as much as possible so I would strongly prefer to just include config in package.json as it is for other packages aka test:unit: "yarn g:jest -c ../../jest.config.native.js"
There was a problem hiding this comment.
If jest.config.js is specified, IDE is able to pick it up and use when running test. It is possible to run tests from IDE even without the explicit config, but it is required to define configuration, which is IMO a bit inconvenient.
I can definitely remove it, just sharing my reasoning.
jbazant
force-pushed
the
testing-library
branch
from
44de5a8 to
3d20502
Compare
Nodonisko
approved these changes
Jan 17, 2025
vytick
added
the
no-project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reintroduction of testing-library to our code base.
test-utilsmodulejest.config.native.js