Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite): Add parameters for window size (electron) from terminal #16324

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

jvaclavik
Copy link
Contributor

@jvaclavik jvaclavik commented Jan 13, 2025

Description

How to use it:

in @trezor/suite-desktop: run:

yarn electron . --width=1200 --height=100
image

Warning: there are limits for window sizes in packages/suite-desktop-core/src/libs/screen.ts

image

@Vere-Grey Vere-Grey self-requested a review January 15, 2025 16:13
@jvaclavik jvaclavik force-pushed the electron-window-size-by-params branch from a5c9310 to dc47b44 Compare January 15, 2025 18:47
@jvaclavik jvaclavik force-pushed the electron-window-size-by-params branch from dc47b44 to 1540d74 Compare January 16, 2025 06:42
@jvaclavik jvaclavik requested a review from adamhavel January 16, 2025 06:45
@jvaclavik jvaclavik merged commit a26cc38 into develop Jan 16, 2025
25 checks passed
@jvaclavik jvaclavik deleted the electron-window-size-by-params branch January 16, 2025 07:21
@bosomt
Copy link
Contributor

bosomt commented Jan 16, 2025

QA OK

Info:

  • Suite version: desktop 25.2.0 (28f0437)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/25.2.0 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.7 regular (revision 8a254aa8eae82f99630df63f40e4d290066a3efc)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Approved
Development

Successfully merging this pull request may close these issues.

3 participants