New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(suite): hide malfunctioning cancel button in ConfirmActionModal c… #16007

Draft

mroz22 wants to merge 1 commit into develop from fix/1500

Contributor

mroz22 commented Dec 17, 2024

Calling cancel from the host was always a pain. It never worked correctly, even before #13925 was merged

commit 902d170 only hides the cancel button from the UI. Based on my quick research, it looks like that other button requests are cancelled correctly. Only this one is causing problems (see Cancel PIN setup on host with 2.0.27 and with device T1 disconnects device. #15000)

we might be trying to get it fixed and working but I couldn't find a quick solution, only this workaround.

related issues

fix Cancel PIN setup on host with 2.0.27 and with device T1 disconnects device. #15000

mroz22 force-pushed the fix/1500 branch 3 times, most recently from 8864ac2 to ac019d8 Compare

January 2, 2025 09:59

mroz22 force-pushed the fix/1500 branch 3 times, most recently from c656f14 to 391aeaa Compare

January 16, 2025 16:57


          fix(suite): hide malfunctioning cancel button in ConfirmActionModal c…

0b89591

…omponent; workaround fix #15000

mroz22 force-pushed the fix/1500 branch from 391aeaa to 0b89591 Compare

January 16, 2025 16:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet