wip: core-in-whatever #14740
Closed
wip: core-in-whatever #14740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
changed the title
mroz22
commented
Oct 7, 2024
| @@ -0,0 +1,272 @@ | |||
| import EventEmitter from 'events'; | |||
There was a problem hiding this comment.
this new impl should be implemented in
connect/src/index
and also it can be used in connect-web package that is implemented in suite-web to get rid of iframe.
mroz22
commented
Oct 7, 2024
packages/connect/src/impl/dynamic.ts
Outdated
| @@ -0,0 +1,153 @@ | |||
| import EventEmitter from 'events'; | |||
There was a problem hiding this comment.
just moved from connect-web
mroz22
force-pushed
the
core-in-whatever
branch
from
0042288 to
12ad999
Compare
|
I have moved part of this PR into #14740 So we simplify with the dynamic connect. And later on there can be a follow-up for core-in-module for suite-web. |
karliatto
force-pushed
the
core-in-whatever
branch
from
12ad999 to
f5e8f25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extremely unfinished draft
prereq of #14690
we are a little step from having single nice and clean standardized logic for creating client-facing implementations of connect core (that have additional powers such as impl switching) in pretty much any environment. once this is finished it could help us with: