Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(suite): update security check URLs #14676

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

komret
Copy link
Contributor

@komret komret commented Oct 2, 2024

Provide different URLs for failed revision/authenticity checks. There used to be one article, now there are two. Clicking "Contact Trezor Support" takes you to a corresponding page, depending on whether firmware revision or device authenticity check failed.
Screenshot 2024-10-02 at 11 22 01

@komret komret added the release Will be included in the upcoming release. Needs to be backported to the release branch. label Oct 2, 2024
@komret komret requested a review from peter-sanderson October 2, 2024 09:23
@komret komret requested a review from marekrjpolak as a code owner October 2, 2024 09:23
Copy link
Contributor

@Lemonexe Lemonexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ the links do not exist yet at trezor.io, so I assume they are planned.

Otherwise LGTM, thee appropriate URLs are shown where they are expected.

Copy link
Contributor

@marekrjpolak marekrjpolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As he said ☝️

@MiroslavProchazka
Copy link
Contributor

They are live ❤️

@Lemonexe Lemonexe merged commit 03d3983 into develop Oct 7, 2024
25 checks passed
@Lemonexe Lemonexe deleted the chore/security-check-urls branch October 7, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Will be included in the upcoming release. Needs to be backported to the release branch.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants