feat(suite): Add cursor: not-allowed to some components when disabled #13251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstastna
force-pushed
the
feat/12945-add-cursor-not-allowed-more-components
branch
from
779f393 to
249a9b9
Compare
hstastna
force-pushed
the
feat/12945-add-cursor-not-allowed-more-components
branch
2 times, most recently
from
34c3b52 to
d1a3b60
Compare
hstastna
force-pushed
the
feat/12945-add-cursor-not-allowed-more-components
branch
from
d1a3b60 to
276285a
Compare
packages/components/src/components/form/SelectBar/SelectBar.tsx
Outdated
Show resolved
Hide resolved
hstastna
force-pushed
the
feat/12945-add-cursor-not-allowed-more-components
branch
from
1a07151 to
e099ff6
Compare
peter-sanderson
approved these changes
Jul 12, 2024
hstastna
force-pushed
the
feat/12945-add-cursor-not-allowed-more-components
branch
from
e099ff6 to
122c038
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
cursor: not-allowedfor cursor to look nicer to some more of the interactive/input components in our design system, when being disabled.Additionally, add args and argTypes in storybook for components that are missing them so one could easily change the values of selected component's props in storybook.
This PR takes care about the following components:
AutoscalingInputRangeSelectSelectBarSwitchAlso for
Buttoncomponent, add way to choose from all the available icons in storybook, incl. choosing the option "No icon" in storybook, as the icon prop is optional.For
AutoscalingInput, add story for playing with its props, use the existing one to just show the examples.TODO (in followup PR):
TextareaIconButtonPinButtonTextButtonTooltipButtonRelated Issue
Resolve #12945
Screenshots:
Before:
Example:
LabelcomponentAfter:
Example:
Labelcomponent: updated cursor when disabled + added more controls to storybookButton component: now you can easily choose an icon if you want, or also not:
