fix(suite-native): useEmptyPassphrase on undefined device instance #12477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juriczech
requested review from
matejkriz,
PeKne,
komret,
szymonlesisz and
mroz22
and removed request for
matejkriz and
PeKne
juriczech
force-pushed
the
fix/native/locked-device-instance
branch
from
233a408 to
e7c057c
Compare
matejkriz
reviewed
May 20, 2024
juriczech
force-pushed
the
fix/native/locked-device-instance
branch
from
e7c057c to
53ce91b
Compare
matejkriz
approved these changes
May 20, 2024
juriczech
force-pushed
the
fix/native/locked-device-instance
branch
from
53ce91b to
34b5335
Compare
juriczech
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After locking,
features.passphrase_protectionreturnsnull, which sets thedeviceInstanceto undefined, which results in settingsuseEmptyPassphraseto false, resulting in triggering the passphrase flow.Related Issue
Resolve #12471
Screenshots: