Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cursor:not-allowed to disable components #12945

Closed
jvaclavik opened this issue Jun 18, 2024 · 5 comments · Fixed by #12969, #13251 or #13759
Closed

Add cursor:not-allowed to disable components #12945

jvaclavik opened this issue Jun 18, 2024 · 5 comments · Fixed by #12969, #13251 or #13759
Assignees
@hstastna

Comments

@jvaclavik
Copy link
Contributor

jvaclavik commented Jun 18, 2024 •
edited
Loading

To all interactive/input components in our design system, we want to add cursor: not-allowed when they are disabled.

Components:

Input
Button
ButttonGroup (maybe it will work when you change it in Button)
Radio
Checkbox
AutoscalingInput
Range
Select
SelectBar (?)
Switch
Textarea

ButtonGroup
IconButton
PinButton
TextButton
TooltipButton
@github-project-automation github-project-automation bot moved this to 🎯 To do in Issues Suite Jun 18, 2024
@hstastna
Copy link
Contributor

Note:
Solving this issue will include also adding args in storybook for components that are missing them so one could easily change the values of selected component and to see how the component behaves/changes.

hstastna added a commit that referenced this issue Jun 19, 2024
@hstastna
feat(suite): Add cursor: not-allowed to disabled components (#12945)
52d3c5b
@hstastna hstastna mentioned this issue Jun 19, 2024
Merged
10 tasks
@hstastna hstastna moved this from 🎯 To do to 🏃‍♀️ In progress in Issues Suite Jun 20, 2024
hstastna added a commit that referenced this issue Jun 20, 2024
@hstastna
feat(suite): Add cursor: not-allowed to disabled components (#12945)
c1d48de
hstastna added a commit that referenced this issue Jun 20, 2024
@hstastna
feat(suite): Add cursor: not-allowed to disabled components (#12945)
68c2e5f
hstastna added a commit that referenced this issue Jun 20, 2024
@hstastna
feat(suite): Add cursor: not-allowed to disabled components (#12945)
d27937a
hstastna added a commit that referenced this issue Jun 24, 2024
@hstastna
feat(suite): Add cursor: not-allowed to disabled components (#12945)
307c74c
hstastna added a commit that referenced this issue Jun 24, 2024
@hstastna
fixup! feat(suite): Add cursor: not-allowed to disabled components (#…
d8aad00 
…12945)
hstastna added a commit that referenced this issue Jun 24, 2024
@hstastna
fixup! fixup! feat(suite): Add cursor: not-allowed to disabled compon…
50c9513 
…ents (#12945)
hstastna added a commit that referenced this issue Jul 1, 2024
@hstastna
feat(suite): Add cursor: not-allowed to disabled components (#12945)
570ecdf
hstastna added a commit that referenced this issue Jul 1, 2024
@hstastna
fixup! feat(suite): Add cursor: not-allowed to disabled components (#…
9a07b50 
…12945)
hstastna added a commit that referenced this issue Jul 1, 2024
@hstastna
fixup! fixup! feat(suite): Add cursor: not-allowed to disabled compon…
1702a95 
…ents (#12945)
hstastna added a commit that referenced this issue Jul 1, 2024
@hstastna
feat(suite): Add cursor: not-allowed to disabled components (#12945)
fe8e09b
hstastna added a commit that referenced this issue Jul 1, 2024
@hstastna
feat(suite): Add cursor: not-allowed to disabled components (#12945)
204416f
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Issues Suite Jul 1, 2024
@hstastna hstastna reopened this Jul 1, 2024
@github-project-automation github-project-automation bot moved this from 🤝 Needs QA to 🎯 To do in Issues Suite Jul 1, 2024
@hstastna
Copy link
Contributor

hstastna commented Jul 1, 2024 •
edited
Loading

The following components are done:

  • Input
  • Button, ButttonGroup
  • Radio
  • Checkbox

The rest in followup PRs.

@hstastna hstastna moved this from 🎯 To do to 🏃‍♀️ In progress in Issues Suite Jul 1, 2024
hstastna added a commit that referenced this issue Jul 9, 2024
@hstastna
feat(suite): Add cursor: not-allowed to some components when disabled (…
779f393 
…#12945)
@hstastna hstastna mentioned this issue Jul 9, 2024
Merged
5 tasks
hstastna added a commit that referenced this issue Jul 9, 2024
@hstastna
feat(suite): Add cursor: not-allowed to some components when disabled (…
249a9b9 
…#12945)
hstastna added a commit that referenced this issue Jul 9, 2024
@hstastna
feat(suite): Add cursor: not-allowed to some components when disabled (…
34c3b52 
…#12945)
hstastna added a commit that referenced this issue Jul 10, 2024
@hstastna
feat(suite): Add cursor: not-allowed to some components when disabled (…
d1a3b60 
…#12945)
hstastna added a commit that referenced this issue Jul 11, 2024
@hstastna
feat(suite): Add cursor: not-allowed to some components when disabled (…
276285a 
…#12945)
hstastna added a commit that referenced this issue Jul 12, 2024
@hstastna
fixup! feat(suite): Add cursor: not-allowed to some components when d…
1a07151 
…isabled (#12945)
hstastna added a commit that referenced this issue Jul 12, 2024
@hstastna
feat(suite): Add cursor: not-allowed to some components when disabled (…
fe19ef6 
…#12945)
hstastna added a commit that referenced this issue Jul 12, 2024
@hstastna
fixup! feat(suite): Add cursor: not-allowed to some components when d…
e099ff6 
…isabled (#12945)
hstastna added a commit that referenced this issue Jul 12, 2024
@hstastna
feat(suite): Add cursor: not-allowed to some components when disabled (…
122c038 
…#12945)
hstastna added a commit that referenced this issue Jul 12, 2024
@hstastna
feat(suite): Add cursor: not-allowed to some components when disabled (…
dd008d0 
…#12945)
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Issues Suite Jul 12, 2024
@hstastna hstastna reopened this Jul 12, 2024
@github-project-automation github-project-automation bot moved this from 🤝 Needs QA to 🎯 To do in Issues Suite Jul 12, 2024
@hstastna
Copy link
Contributor

Update: The following components are done:

  • Input
  • Button, ButttonGroup
  • Radio
  • Checkbox
  • AutoscalingInput
  • Range
  • Select
  • SelectBar
  • Switch

The rest in followup PR (hopefully the last one).

@hstastna hstastna moved this from 🎯 To do to 🏃‍♀️ In progress in Issues Suite Jul 12, 2024
@hstastna
Copy link
Contributor

hstastna commented Aug 11, 2024 •
edited
Loading

Note:
PinButton component cannot be disabled, hence cursor:not-allowed won't be added to it as it does not make sense (probably only its storybook will be updated).

hstastna added a commit that referenced this issue Aug 11, 2024
@hstastna
feat(suite): Add cursor: not-allowed to some components when disabled (…
c66a65f 
…#12945)

Add cursor: not-allowed for cursor to look nicer for the following
components:
- Textarea
- IconButton
- TextButton
- TooltipButton
Update the related storybooks, add missing controls.
@hstastna hstastna mentioned this issue Aug 11, 2024
Merged
hstastna added a commit that referenced this issue Aug 11, 2024
@hstastna
feat(suite): Add cursor: not-allowed to some components when disabled (…
80e26db 
…#12945)

Add cursor: not-allowed for cursor to look nicer for the following
components:
- Textarea
- IconButton
- TextButton
- TooltipButton
Update the related storybooks, add missing controls.
hstastna added a commit that referenced this issue Aug 14, 2024
@hstastna
feat(suite): Add cursor: not-allowed to some components when disabled (…
4c5dffc 
…#12945)

Add cursor: not-allowed for cursor to look nicer for the following
components:
- Textarea
- IconButton
- TextButton
- TooltipButton
Update the related storybooks, add missing controls.
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Issues Suite Aug 14, 2024
@bosomt
Copy link
Contributor

bosomt commented Aug 15, 2024

QA OK

Screen.Recording.2024-08-15.at.16.32.05.mov

Info:

  • Suite version: web 24.9.0 (6d647cf)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:129.0) Gecko/20100101 Firefox/129.0
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.8.1 regular (revision 632b9561559b7ab6824bb7eeac072874e07b7b82)
  • Transport: BridgeTransport 2.0.32

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hstastna hstastna

Labels
None yet
Projects
Issues Suite
Archived in project
Milestone
No milestone
3 participants
@jvaclavik @hstastna @bosomt