fix(suite): render supported coins only once in add account modal (#1…

…6280) * fix(suite): render supported coins only once in add account modal * fix(suite): fix tests * fix(suite): fix test * fix(e2e): adds missing skip firmware step to t2t1 tests --------- Co-authored-by: STew790 <[email protected]> Co-authored-by: Martin Vere Cihlar <[email protected]>
trezor · Jan 10, 2025 · d57443e · d57443e
1 parent 53c05a0
commit d57443e
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 5 deletions.
diff --git a/packages/suite-desktop-core/e2e/tests/onboarding/t2t1/t2t1-create-wallet.test.ts b/packages/suite-desktop-core/e2e/tests/onboarding/t2t1/t2t1-create-wallet.test.ts
@@ -1,3 +1,4 @@
+import { isWebProject } from '../../../support/common';
 import { SeedType } from '../../../support/enums/seedType';
 import { test, expect } from '../../../support/fixtures';
 
@@ -19,9 +20,13 @@ test.describe('Onboarding - create wallet', { tag: ['@group=device-management']
         onboardingPage,
         devicePrompt,
         trezorUserEnvLink,
-    }) => {
+    }, testInfo) => {
         await analyticsPage.passThroughAnalytics();
-        await onboardingPage.firmware.continueButton.click();
+        if (isWebProject(testInfo)) {
+            await onboardingPage.firmware.skip();
+        } else {
+            await onboardingPage.firmware.continueButton.click();
+        }
 
         // Will be clicking on Shamir backup button
         await onboardingPage.createWalletButton.click();

diff --git a/packages/suite-desktop-core/e2e/tests/onboarding/t2t1/t2t1-recovery-fail.test.ts b/packages/suite-desktop-core/e2e/tests/onboarding/t2t1/t2t1-recovery-fail.test.ts
@@ -1,3 +1,4 @@
+import { isWebProject } from '../../../support/common';
 import { test } from '../../../support/fixtures';
 
 test.describe('Onboarding - recover wallet T2T1', { tag: ['@group=device-management'] }, () => {
@@ -18,11 +19,15 @@ test.describe('Onboarding - recover wallet T2T1', { tag: ['@group=device-managem
         analyticsPage,
         devicePrompt,
         trezorUserEnvLink,
-    }) => {
+    }, testInfo) => {
         await analyticsPage.passThroughAnalytics();
+        if (isWebProject(testInfo)) {
+            await onboardingPage.firmware.skip();
+        } else {
+            await onboardingPage.firmware.continueButton.click();
+        }
 
         // Start wallet recovery process and confirm on device
-        await onboardingPage.firmware.continueButton.click();
         await onboardingPage.recoverWalletButton.click();
         await onboardingPage.startRecoveryButton.click();
         await devicePrompt.confirmOnDevicePromptIsShown();

diff --git a/packages/suite-web/e2e/tests/wallet/add-account-types.test.ts b/packages/suite-web/e2e/tests/wallet/add-account-types.test.ts
@@ -75,6 +75,7 @@ describe('Account types suite', () => {
                 // Test execution
                 //
                 onAccountsPage.clickAllAccountArrows();
+                cy.getTestElement(`@account-menu/normal`).click();
 
                 // for a specific type of BTC acc, get the current number of accounts
                 cy.getTestElement(`@account-menu/${type}/group`)

diff --git a/...c/components/suite/modals/ReduxModal/UserContextModal/AddAccountModal/AddAccountModal.tsx b/...c/components/suite/modals/ReduxModal/UserContextModal/AddAccountModal/AddAccountModal.tsx
@@ -230,7 +230,7 @@ export const AddAccountModal = ({
                               )}
                               <SelectNetwork
                                   heading={<Translation id="TR_INACTIVE_COINS" />}
-                                  networks={visibleNetworks}
+                                  networks={symbol ? visibleNetworks : disabledMainnetNetworks}
                                   selectedNetworks={selectedNetworks}
                                   handleNetworkSelection={selectNetwork}
                               />