Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix gfx_bitblt initialization #4514

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

cepetr
Copy link
Contributor

@cepetr cepetr commented Jan 17, 2025

This PR simplifies the initialization of the gfx_bitblt module (DMA2D). The gfx_bitblt module no longer requires explicit initialization, as it is now automatically initialized along with the display driver.

Additionally, this PR fixes a bug introduced in commit d4cd1a3. In rescue mode, DMA2D was deinitialized but not reinitialized before displaying the RSOD screen.

@cepetr cepetr requested a review from TychoVrahe January 17, 2025 11:12
@cepetr cepetr self-assigned this Jan 17, 2025
@cepetr cepetr added T3T1 Trezor Safe 5 T2T1 Trezor Model T labels Jan 17, 2025
Copy link

github-actions bot commented Jan 17, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@cepetr cepetr force-pushed the cepetr/fix-gfxbitblt branch from 7372c53 to ce261e8 Compare January 17, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2T1 Trezor Model T T3T1 Trezor Safe 5
Projects
Status: 🔎 Needs review
Development

Successfully merging this pull request may close these issues.

1 participant