Make button press cancel current hold #4509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bieleluk
approved these changes
Jan 16, 2025
| self.right_btn.hold_canceled(ctx); | ||
| return None; | ||
| } | ||
| _ => {} |
There was a problem hiding this comment.
Because the power button does not exist in t2b1 nor t3b1 models, I would suggest returning None even in this case and remove returning of the ButtonState::BothDown after the added match statement
Suggested change
| _ => {} | |
| _ => { | |
| return None; | |
| } |
There was a problem hiding this comment.
OK, just returned None in all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On TS3, when holding a button to confirm, pressing the other button now cancels the "hold".
Note: we want to cancel it without an animation rather than with the "shrinking" animation as if the held button was released!