Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove optional dependency on cryptography #4507

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove optional dependency on cryptography #4507

wants to merge 1 commit into from

Conversation

ibz
Copy link
Contributor

@ibz ibz commented Jan 16, 2025 •
edited
Loading

See #4493

@ibz ibz self-assigned this Jan 16, 2025
@ibz ibz linked an issue Jan 16, 2025 that may be closed by this pull request
Transitive dependency - cryptography is no longer optional #4493
Open
@ibz ibz changed the title chore(core): remove optional dependency Remove optional dependency on cryptography Jan 16, 2025
@github-actions GitHub Actions
Copy link

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@matejcik
Copy link
Contributor

instead of dropping, we want to move it to explicit required dependencies, and adjust the command trezorctl device authenticate that has some logic for when cryptography is not present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejcik matejcik Awaiting requested review from matejcik matejcik will be requested when the pull request is marked ready for review matejcik is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@ibz ibz

Labels
None yet
Projects
Firmware
Status: 🔎 Needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transitive dependency - cryptography is no longer optional
2 participants
@ibz @matejcik