split polling can_read and reading from USB #4419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TychoVrahe
force-pushed
the
tychovrahe/refactor/usb_split
branch
from
86f3140 to
e942f8e
Compare
|
Tangential: do we still use HID anywhere in Core? Maybe it is time to remove it (in different PR)? |
FIDO runs over HID |
matejcik
reviewed
Dec 4, 2024
TychoVrahe
requested review from
prusnak and
matejcik
and removed request for
prusnak
matejcik
reviewed
Dec 5, 2024
matejcik
reviewed
Dec 5, 2024
Merged
matejcik
requested changes
Jan 13, 2025
There was a problem hiding this comment.
pushed a fixup 6ef3b8b to your branch that implements better buffer handling in codec_v1. Tried to do the same thing for FIDO but backed out because of the frankly insane use of overlay_struct, so a much more careful approach would be needed.
ACK on the new API, just some nits to fix
matejcik
approved these changes
Jan 13, 2025
TychoVrahe
force-pushed
the
tychovrahe/refactor/usb_split
branch
from
7d2f091 to
c3e50d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way reading from USB works: the polling mechanism is only used to detect if there is a new message, the reading itself is done separately.
The emulator implementation is modified a bit, since there is a need to do the PING-PONG and it is undesirable to emit a CAN_READ event due to this- therefore the message is read into buffer during polling, and the read from the buffer upon read.
This should enable some optimized usage of the message buffer, but this is not done in this PR.