Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPU initialization refactoring #3394

Merged
merged 1 commit into from
Nov 15, 2023
Merged

MPU initialization refactoring #3394

merged 1 commit into from
Nov 15, 2023

Conversation

cepetr
Copy link
Contributor

@cepetr cepetr commented Nov 7, 2023

I've refactored MPU initialization routine to be more clear and maintainable. Now it's just a draft for further discussion.

@cepetr cepetr added the T3T1 Trezor Safe 5 label Nov 7, 2023
@cepetr cepetr requested a review from TychoVrahe November 7, 2023 12:07
@cepetr cepetr self-assigned this Nov 7, 2023
@cepetr cepetr requested a review from prusnak as a code owner November 7, 2023 12:07
@TychoVrahe TychoVrahe force-pushed the tychovrahe/u5/basic_support branch from b66856a to 8d78b28 Compare November 7, 2023 12:52
@cepetr cepetr force-pushed the cepetr/u5/mpu-refactor branch from fd65e2d to 8bac1f7 Compare November 7, 2023 13:37
TychoVrahe
TychoVrahe reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@TychoVrahe TychoVrahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple clarifications for the problems discovered during refactoring below.

Note that the region sizes will need adjustments for final MCU variants (U585 and U5Gx likely).

core/embed/trezorhal/stm32u5/mpu.c Outdated Show resolved Hide resolved
core/embed/trezorhal/stm32u5/mpu.c Outdated Show resolved Hide resolved
core/embed/trezorhal/stm32u5/mpu.c Outdated Show resolved Hide resolved
core/embed/trezorhal/stm32u5/mpu.c Outdated Show resolved Hide resolved
core/embed/trezorhal/stm32u5/mpu.c Outdated Show resolved Hide resolved
TychoVrahe
TychoVrahe approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@TychoVrahe TychoVrahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please fix the residual style issues, squash and add [no changelog] to the commit message

@cepetr cepetr force-pushed the cepetr/u5/mpu-refactor branch from dea90d4 to 61c55ee Compare November 14, 2023 12:43
@cepetr cepetr force-pushed the cepetr/u5/mpu-refactor branch from 1b320f7 to 1a67626 Compare November 14, 2023 15:04
@TychoVrahe TychoVrahe merged commit 05a982b into tychovrahe/u5/basic_support Nov 15, 2023
7 of 8 checks passed
@TychoVrahe TychoVrahe deleted the cepetr/u5/mpu-refactor branch November 15, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TychoVrahe TychoVrahe TychoVrahe approved these changes

@prusnak prusnak Awaiting requested review from prusnak

@andrewkozlik andrewkozlik Awaiting requested review from andrewkozlik

@matejcik matejcik Awaiting requested review from matejcik

Assignees

@cepetr cepetr

Labels
T3T1 Trezor Safe 5
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cepetr @TychoVrahe