allow resource names >2 parts #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #343 +/- ##
=======================================
Coverage 27.35% 27.35%
=======================================
Files 795 795
Lines 96326 96341 +15
=======================================
+ Hits 26347 26352 +5
- Misses 69979 69989 +10 ☔ View full report in Codecov by Sentry. |
|
I amended my commit to add a UT. |
tomplus
reviewed
Dec 6, 2024
Dynamic client discovery for resources with three part names, the processing fails. Allow for processing names with >2 parts. This was failing on an OpenShift environment with the resource 'virtualmachineinstances/sev/fetchcertchain'
Glad to help! Thank you for this project, it will make enabling an K8s EDA event source possible. I think you need to approve the workflow to validate execution again. |
tomplus
pushed a commit
that referenced
this pull request
Dec 8, 2024
Dynamic client discovery for resources with three part names, the processing fails. Allow for processing names with >2 parts. This was failing on an OpenShift environment with the resource 'virtualmachineinstances/sev/fetchcertchain' Co-authored-by: ejacques <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic client discovery for resources with three part names, the processing fails. Allow for processing names with >2 parts.
This was failing on an OpenShift environment with the resource 'virtualmachineinstances/sev/fetchcertchain'
#342