Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for Windows-forbidden characters in the filename #353

Merged
merged 29 commits into from
Oct 4, 2024

Conversation

sebastiaanspeck
Copy link
Member

@sebastiaanspeck sebastiaanspeck self-assigned this Sep 29, 2024
@sebastiaanspeck sebastiaanspeck changed the title Add check for Windows-illegal characters in the filename Add check for Windows-forbidden characters in the filename Sep 29, 2024
@sebastiaanspeck
Copy link
Member Author

Adding a real 111<.md file causes the checkout to fail on Windows (obviously).

@sebastiaanspeck sebastiaanspeck marked this pull request as ready for review September 29, 2024 19:12
@sebastiaanspeck
Copy link
Member Author

We could argue if we want to name the new check TLDR110, since all of those affect the filename, and rename the previous TLDR110 to TLDR111.

@sebastiaanspeck
Copy link
Member Author

We could argue if we want to name the new check TLDR110, since all of those affect the filename, and rename the previous TLDR110 to TLDR111.

@kbdharun the 👍🏼 means that you agree? If so, I will change the new check to TLDR110.

@owenvoke
Copy link
Member

owenvoke commented Oct 4, 2024

Personally I would say we shouldn't rename TLDR checks as people may be relying on the error codes. 🤔 Especially as this has been out since March. 👀

Even if it looks a bit weird having some that are related to files in different locations, it should be in the order we add them. 👍🏻 Otherwise, if we add a filename rule in 20 rules time, we'd have to reorder them all again.

@sebastiaanspeck
Copy link
Member Author

I will add a line in the changelog and then this PR is GTG

@sebastiaanspeck sebastiaanspeck merged commit 207c862 into main Oct 4, 2024
16 checks passed
@sebastiaanspeck sebastiaanspeck deleted the feature/windows-illegal-chars branch October 4, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants