-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for Windows-forbidden characters in the filename #353
Conversation
Adding a real |
We could argue if we want to name the new check TLDR110, since all of those affect the filename, and rename the previous TLDR110 to TLDR111. |
@kbdharun the 👍🏼 means that you agree? If so, I will change the new check to TLDR110. |
Personally I would say we shouldn't rename TLDR checks as people may be relying on the error codes. 🤔 Especially as this has been out since March. 👀 Even if it looks a bit weird having some that are related to files in different locations, it should be in the order we add them. 👍🏻 Otherwise, if we add a filename rule in 20 rules time, we'd have to reorder them all again. |
I will add a line in the changelog and then this PR is GTG |
#352