*: rename file and clean up #8996
Conversation
Signed-off-by: Ryan Leung <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
size/M
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8996 +/- ##
==========================================
- Coverage 76.33% 76.30% -0.03%
==========================================
Files 465 465
Lines 70565 70556 -9
==========================================
- Hits 53867 53840 -27
- Misses 13355 13371 +16
- Partials 3343 3345 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Ryan Leung <[email protected]>
| c.serviceMode = newMode | ||
| log.Info("[pd] service mode changed", |
There was a problem hiding this comment.
Do we need to keep one of the two logs?
There was a problem hiding this comment.
We can, but I don't want to expose the API mode. Any idea?
There was a problem hiding this comment.
if newMode != pdpb.ServiceMode_PD_SVC_MODE {
log.Info("[pd] changing from non-microservice to microservice")
}else{
log.Info("[pd] changing from microservice to non-microservice")
}
There was a problem hiding this comment.
Is it similar to line 87 and line 91?
There was a problem hiding this comment.
resetTSOClientLocked and setServiceMode may be called at different places?
| @@ -321,7 +321,7 @@ func svcRootPath(svcName string) string { | |||
| return path.Join(constant.MicroserviceRootPath, c, svcName) | |||
| } | |||
|
|
|||
| // LegacyRootPath returns the root path of legacy pd service. | |||
| // LegacyRootPath returns the root path of legacy PD. | |||
There was a problem hiding this comment.
Do we need to replace legacy with non-microservice env?
There was a problem hiding this comment.
The function name uses "legacy", I just keep using it.
What problem does this PR solve?
Issue Number: ref #5766
What is changed and how does it work?
Check List
Tests
Release note