txn: store last commit transaction's info #1537
Open
+311
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/XL
Signed-off-by: you06 <[email protected]> fix test Signed-off-by: you06 <[email protected]> update tidb Signed-off-by: you06 <[email protected]> check commit ts in oracle Signed-off-by: you06 <[email protected]> update Signed-off-by: you06 <[email protected]>
you06
force-pushed
the
store-level-commit-ts-check
branch
from
e122acd to
7c20c70
Compare
cfzjywxk
reviewed
Dec 31, 2024
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
cfzjywxk
reviewed
Jan 14, 2025
| txnScope string | ||
| o *pdOracle | ||
| txnScope string | ||
| commitInfo *util.CommitInfo |
There was a problem hiding this comment.
Perhaps lastCommitInfo is better.
| @@ -1903,6 +1905,7 @@ func (c *twoPhaseCommitter) execute(ctx context.Context) (err error) { | |||
| } | |||
| } | |||
| atomic.StoreUint64(&c.commitTS, commitTS) | |||
| c.updateStoreCommitInfo() | |||
There was a problem hiding this comment.
The transaction is not ensured to be committed successfully here, for example, if 2PC is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: pingcap/tidb#57165
Implement this comment: #1489 (review)