txnkv/transaction/prewrite: tiny refactor HandleSingleBatch #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
dco-signoff: yes
Signed-off-by: AndreMouche <[email protected]>
AndreMouche
force-pushed
the
handleSingleBatch
branch
from
e2980be to
0df9619
Compare
Signed-off-by: AndreMouche <[email protected]>
Signed-off-by: AndreMouche <[email protected]>
you06
reviewed
Dec 27, 2024
ekexium
reviewed
Jan 2, 2025
Signed-off-by: AndreMouche <[email protected]>
Signed-off-by: AndreMouche <[email protected]>
Signed-off-by: AndreMouche <[email protected]>
Signed-off-by: AndreMouche <[email protected]>
Signed-off-by: AndreMouche <[email protected]>
Signed-off-by: AndreMouche <[email protected]>
Signed-off-by: AndreMouche <[email protected]>
you06
approved these changes
Jan 6, 2025
ti-chi-bot
bot
added
needs-1-more-lgtm
cfzjywxk
approved these changes
Jan 15, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, you06 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do some tiny refactor for
handleSingleBatchExtracted some functions to make more friendly to reviewers and maintainers, meanwhile make the unit testing easier to write too