Fix the problem that ttlManager may stop working if no need to lock after retry aggressive locking #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter retry aggressive locking Signed-off-by: MyonKeminta <[email protected]>
ti-chi-bot
bot
added
dco-signoff: yes
ti-chi-bot
bot
added
the
do-not-merge/work-in-progress
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
cfzjywxk
reviewed
Dec 16, 2024
ekexium
approved these changes
Dec 17, 2024
txnkv/transaction/txn.go
Outdated
| // acquirePessimisticLock requests, it will call ttlManager.run() again, but it's reentrant and will do nothing | ||
| // as the ttlManager is already running. | ||
| // * If the primary key is changed, the ttlManager will need to run on the new primary key instead. Reset it. | ||
| if !noNewLockToAcquire && !bytes.Equal(txn.aggressiveLockingContext.primaryKey, txn.aggressiveLockingContext.lastPrimaryKey) { |
There was a problem hiding this comment.
Maybe replacing !noNewLockToAcquire with hasNewLockToAcquire is more idiomatic and makes the code more readable
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: MyonKeminta <[email protected]>
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, ekexium The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: pingcap/tidb#58279