Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add software button for touch screen #17

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

manato
Copy link
Collaborator

@manato manato commented Dec 15, 2024

Description

This PR adds a software button to control DRS service reboot/shutdown without mechanical switches, especially on touch-screen enviroment.

Tests performed

DRS_RECORD_ROOT_DIR=/tmp ros2 launch simple_frontend simple_frontend.launch.xml has_mechanical_switch:=False

  • DRS_RECORD_ROOT_DIR: an environmental variable to be monitored by simple_frontend. On the actual system environment, this variable should point the NAS-mounted directory
  • has_mechanical_switch: default=False

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@manato manato requested review from 0x126, drwnz and miursh December 15, 2024 11:44
@0x126
Copy link
Collaborator

0x126 commented Dec 15, 2024

I have confirmed that the button works.
image

@manato manato merged commit 9b1f735 into feat/L4T-R35.4.1 Dec 16, 2024
4 of 6 checks passed
@manato manato deleted the feat/add_button_for_touch_screen branch December 16, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants