👷Exclude jobs from non existent matrix

thefrontside · Nov 26, 2024 · e3af7eb · e3af7eb
1 parent 39d0b5c
commit e3af7eb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml
@@ -22,6 +22,7 @@ jobs:
         id: set-matrix
 
   jsr:
+    if: matrix.exists
     name: Publish ${{ matrix.name }}@${{matrix.version}} to JSR
     runs-on: ubuntu-latest
 
@@ -43,6 +44,7 @@ jobs:
       - run: deno publish
         working-directory: ${{ matrix.workspace }}
   npm:
+    if: matrix.exists
     name: Publish ${{ matrix.name }}@${{matrix.version}} to NPM
     runs-on: ubuntu-latest
 
@@ -73,6 +75,7 @@ jobs:
           NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
 
   tag:
+    if: matrix.exists
     name: "Tag Release"
     runs-on: ubuntu-latest
     needs: [generate-matrix, jsr, npm]

diff --git a/www/tasks/publish-matrix.ts b/www/tasks/publish-matrix.ts
@@ -29,6 +29,7 @@ await main(function* () {
     // ergo we publish
     if (output.join("").trim() === "") {
       include.push({
+        exists: true,
         workspace: pkgmeta.workspace,
         tagname,
         name: pkg.name,
@@ -37,9 +38,12 @@ await main(function* () {
     }
   }
 
-  let matrix = JSON.stringify(include.length > 0 ? { include } : {});
+  // we must have a valid matrix, but don't always do anything
+  if (include.length === 0) {
+    include.push({ exists: true });
+  }
 
-  let outputValue = `matrix=${matrix}`;
+  let outputValue = `matrix=${JSON.stringify({ include })}`;
 
   if (Deno.env.has("GITHUB_OUTPUT")) {
     const githubOutput = Deno.env.get("GITHUB_OUTPUT") as string;