Fix eslint command to run on all files #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
The eslint command didnt specify which files to run on, so it never checked anything and always passed with usage info:
#!/bin/bash -eo pipefail yarn eslint --max-warnings=0 --format junit --output-file ./reports/eslint/eslint.xml yarn run v1.19.1 $ /home/circleci/project/node_modules/.bin/eslint --max-warnings=0 --format junit --output-file ./reports/eslint/eslint.xml eslint [options] file.js [file.js] [dir]
See: https://circleci.com/gh/slaweet/github-commit-punch-chart/194
How did I fix it?
By telling eslint to run on all files in the repo (
.
)How did I test it?
I tested it only by running the command locally in my repo, so I'm not sure if this is needed for everyone. Let me know what do you think 🙂