Allow passing extra environment variables to PuppetCommand.format_command #378
+22
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Oct 18, 2024
|
Note in #374 I also started to add tests. Should we build on that? |
|
I just rebased it to make RuboCop green. |
evgeni
force-pushed
the
extra-env
branch
2 times, most recently
from
c89f25d to
9bdbf74
Compare
ekohl
approved these changes
Oct 18, 2024
evgeni
commented
Oct 18, 2024
| [::ENV] + cmd + [:unsetenv_others => false] | ||
| [::ENV.to_h.merge(extra_env)] + cmd + [:unsetenv_others => false] |
There was a problem hiding this comment.
Whoever thought it's cool that ::ENV behaves mostly like a Hash, but is not one, needs some vacation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.