Use multiple gh run download commands #3584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 242dde2 I tried to combine multiple downloads into a single command because from the man page made me think that. In practice it says: > accepts at most 1 arg(s), received 3 This splits it back in to 3 separate commands as it previously was. Fixes: 242dde2 ("Use gh run download in previews (theforeman#3579)")
maximiliankolb
approved these changes
Jan 17, 2025
|
https://github.com/theforeman/foreman-documentation/actions/runs/12826749320/job/35767304239 According to the help output of gh 2.51.0, the syntatx is correct. I am out of ideas. @ekohl |
ekohl
commented
Jan 17, 2025
| @@ -45,7 +45,10 @@ jobs: | |||
| run: echo "PR_DATA=$(cat ./pr.json)" >> $GITHUB_ENV | |||
|
|
|||
| - name: Download other artifacts | |||
| run: gh run download {{ github.event.worfklow_run.id }} -n 'foreman-docs-html-${{ fromJSON(env.PR_DATA).branch_name }}' -n foreman-docs-html-base -n foreman-docs-web-master | |||
There was a problem hiding this comment.
I'm blind and I think this should be ${{ github.event.worfklow_run.id }}. Then you can probably still download multiple artifacts at the same time.
ekohl
added a commit
to ekohl/foreman-documentation
that referenced
this pull request
Jan 17, 2025
In 242dde2 I forgot to add $ to the variable, so it was taking it literally. This is something I tried to fix in 313e77e but didn't. Fixes: 242dde2 ("Use gh run download in previews (theforeman#3579)") Fixes: 313e77e ("Use multiple gh run download commands (theforeman#3584)")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
In 242dde2 I tried to combine multiple downloads into a single command because from the man page made me think that. In practice it says:
This splits it back in to 3 separate commands as it previously was.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Becaue I broke things in #3579.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
I'm sorry.
Checklists
Please cherry-pick my commits into: