Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ELS option to convert2rhel #3557

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Conversation

Lennonka
Copy link
Contributor

@Lennonka Lennonka commented Jan 9, 2025

What changes are you introducing?

Adding an option to convert2rhel to convert to a RHEL version in the Extended Lifecycle Support (ELS) phase.
This currently applies to RHEL 7, but I tried to write it in version-neutral terms for future times.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Documents theforeman/foreman_ansible#746, theforeman/foreman_remote_execution#933, and theforeman/foreman_remote_execution#937

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into: N/A

@Lennonka Lennonka added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective labels Jan 9, 2025
@Lennonka
Copy link
Contributor Author

Lennonka commented Jan 9, 2025

@bocekm Can you please review this?

Copy link

github-actions bot commented Jan 9, 2025

@pr-processor pr-processor bot added the Waiting on contributor Requires an action from the author label Jan 10, 2025
Co-authored-by: Michal Bocek <[email protected]>
Co-authored-by: Gaurav Talreja <[email protected]>
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Jan 13, 2025
Copy link
Contributor

@stejskalleos stejskalleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏 LGTM

@Lennonka Lennonka added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective labels Jan 13, 2025
Copy link
Contributor

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the updates!

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style-wise LGTM

@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Jan 14, 2025
@Lennonka Lennonka merged commit 73152cf into theforeman:master Jan 14, 2025
8 of 9 checks passed
@Lennonka Lennonka deleted the add-els-switch-c2r branch January 14, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants