-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ELS option to convert2rhel #3557
Conversation
@bocekm Can you please review this? |
The PR preview for ca35ca9 is available at theforeman-foreman-documentation-preview-pr-3557.surge.sh The following output files are affected by this PR: |
Co-authored-by: Michal Bocek <[email protected]> Co-authored-by: Gaurav Talreja <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍏 LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the updates!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style-wise LGTM
What changes are you introducing?
Adding an option to convert2rhel to convert to a RHEL version in the Extended Lifecycle Support (ELS) phase.
This currently applies to RHEL 7, but I tried to write it in version-neutral terms for future times.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Documents theforeman/foreman_ansible#746, theforeman/foreman_remote_execution#933, and theforeman/foreman_remote_execution#937
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: N/A